Windows test failure about logstash-filter-grok HOT 9 CLOSED

Investigating the cases 41 and 42
For me, on Windows, the WORD definition was overriden by a pattern file in the logstash gem
jruby-1.7.17\lib\ruby\gems\shared\bundler\gems\logstash-2331739bb57e\patterns
as seen in the debug log

←[32mAdding pattern {"WORD"=>"\\b[2-5]\\b", :level=>:info, :file=>"/dev/tools/jruby-1.7.17/lib/ruby/gems/shared/gems/jls-grok-0.11.0/lib/grok-pure.rb", :line=>"62", :method=>"add_pattern"}←[0m

This file remains around because test creating it is failing too, see 46).
https://github.com/logstash-plugins/logstash-filter-grok/blob/master/spec/filters/grok_spec.rb#L671-L696
Any idea how to enforce the cleanup in rspec and reduce such side-effect?

from logstash-filter-grok.

In fact after removing the two last tests implying tempfiles and cleaning the pattern dirs in the gem, the full spec is reliably OK. So it is more an issue about running the spec on windows without tempfile side-effect than a bug in grok itself.

from logstash-filter-grok.

@wiibaa thx for the investigation. 👍 :)

from logstash-filter-grok.

Fixed in:
jordansissel/ruby-grok#16
#10

from logstash-filter-grok.

In my windows box I edited the installed grok-pure lib to ensure closing the file and then pulled pr/10 but I still get 9 failures: https://gist.github.com/jsvd/084f7fcd27508797923b

did I miss some other patch?

from logstash-filter-grok.

@jsvd you should have all the patch for this bug? I suggest you remove the gems reinstall them and use the patch. I think you may have some left over files when the tests had side effects.

from logstash-filter-grok.

I still get this issue after cloning logstash master, applying this PR and the ruby-grok patch manually.
https://gist.github.com/jsvd/51a8111a7d6ba3365868

from logstash-filter-grok.

Confirmed that manually deleting patterns in the patterns\ dir, applying the ruby-grok patch and this patch makes the tests pass inside logstash.
Maybe the test files should be generated in a temporary directory instead of patterns\?
Otherwise LGTM

from logstash-filter-grok.

This is more like an integration test to make sure we can override the pattern in the pattern dir, the other files are generated in a tmp folder.

IMHO, We should revisit all the test examples of the grok filter to refactor them and to use Stud::Temporary

from logstash-filter-grok.