Comments (4)
@ssh24 What's left for this task:
- Ensure
_.rev
is not being altered on any of the remaining CRUD methods. The PR in its current state hasreplaceOrCreate
,updateOrCreate
andcreate
covered (with tests). You'll probably need to make sure that all of the find and destroy functions also do the same thing. - You'll also need to demonstrate that they work across the REST APIs; that is, it should show the
_.rev
property in the returned payloads on GET, and should accept (and use)_.rev
on POST/PUT/PATCH/DELETE
With respect to the Swagger/OpenAPI definitions, we can go one of two routes:
- We inject the
_.rev
property onto models that use a Cloudant datasource, so that it actually shows up as part of the API def. - We document the need to handle
_.rev
and put the onus on the user/developer to add this property to their model definitions.
from loopback-connector-cloudant.
But considering the nature of Cloudant db, we should ask the caller to provide rev, and return error if it's missing.
A big +1 from me.
I believe the field is called _rev
in Cloudant, isn't it? https://docs.cloudant.com/mvcc.html#revisions
I am proposing to define a _rev
property on a model at the time when the model is attached to a Cloudant datasource. That way the _rev
property will be propagated to Swagger too.
The catch is how to tell clients that _rev
should not be included in create
requests? This is similar to the problem of excluding id
property when forceId
is true
, see strongloop/loopback#2924
from loopback-connector-cloudant.
@bajtos ah sorry I forgot to direct you to #54 (comment), I made some comment about how to let callers access _rev
in that link.
The catch is how to tell clients that _rev should not be included in create requests
True, I will look into this part. My suggestion is based on using an option flag to tell function fromDB()
returns _rev
with data or not, so doesn't have this concern.
from loopback-connector-cloudant.
The feature has been landed and awaiting to be released on the next major version. Closing this ticket as a result.
from loopback-connector-cloudant.
Related Issues (20)
- Out dated / error in dependancies HOT 2
- Count returns a max of 25 HOT 5
- Query "like and case insensitive" with issues HOT 7
- Add support Geospatial queries HOT 5
- Fix the filter for hasManyThrough relation HOT 2
- Fix CI - 2 test cases failed HOT 3
- Run shared tests from both v3 and v4 of juggler
- FindById doesn't use Cloudant Read by Id method HOT 8
- [Spike] Add Support for Partitioned Databases HOT 18
- Update driver to nodejs/cloudant HOT 5
- Support creating partitioned index HOT 1
- Optimize query by reading partition key from payload HOT 1
- Compose the _id for a document in a partition database HOT 3
- [Epic] Add Support for Partitioned Database HOT 2
- findAll: Read partitionKey from `options` HOT 3
- Optimize findById for partitioned database HOT 4
- [Epic] Add Support for Partitioned Database (Post MVP) HOT 5
- [Blog] Blog post about the support for partitioned database HOT 2
- Invalid key partitioned using with Cloudant docker locally HOT 6
- Move to @ibm-cloud/cloudant HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from loopback-connector-cloudant.