Giter VIP home page Giter VIP logo

Comments (4)

lorenzwalthert avatar lorenzwalthert commented on July 27, 2024

Can styler be configured to break the lines?

Not yet, and it's the most upvoted feature request. #247

Can lintr be configured to allow longer lines ~100 characters

Possibly, I am not a {lintr} expert. But this should be in the docs of {lintr}. .lintr config file is respected in our pre-commit hooks.

Maybe I am mistaken, but I don't expect any lintr errors after styler runs successfully.

True. Please open issues in {lintr} or {styler} if you have concrete problems. We are working towards compatibility.

All of the above are not {precommit} specific problems though. I just happen to work on {styler} and with contributors of {lintr} so I answered from that perspective. So these are the repos to go to if you experience problems that are unrelated to pre-commit.

from precommit.

lorenzwalthert avatar lorenzwalthert commented on July 27, 2024

As per the efaults are seeminlgyy different in different format checkers, {precommit} does not set any defaults, we just fall back to the defaults of {styler} and {lintr} in that case.

from precommit.

fabianegli avatar fabianegli commented on July 27, 2024

Thank you for the replies and the hint to the .lintr config.

While these issues are indeed caused by upstream projects, the problem surfaces with their combined use in the default precommit configuration. If there is already an ongoing effort to make the two tools compatible, I don't see a reason to add additional issues. Feel free to poke around in this PR (enabling lintr) to see all the issues live - you can probably better judge what's worth reporting and what not.

from precommit.

lorenzwalthert avatar lorenzwalthert commented on July 27, 2024

Ok. Thanks. {styler} won't rename your variables etc. These are linting issues that can't be auto-fixed.

from precommit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.