Giter VIP home page Giter VIP logo

Comments (1)

LowinLi avatar LowinLi commented on June 10, 2024

Thanks, this line is an unnecessary intersection indeed.
But exactly, it is the intersection of two same mention set.

For example, if predicted_clusters is [["a", "b", "c"], ["d", "e", "f", "g"], ["h", "i", "j"], ["k"]]

At the calculate of sum(predicted_clusters, []), we will get the original mention list ['a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j', 'k']. It is the same process in gold_clusters.

All the mentions should exist in one of the predicted_clusters or gold_clusters. So the intersection is unnecessary.

I think in this line, we should add assert. It will be more clear.

assert set(sum(predicted_clusters, [])) == set(sum(gold_clusters, []))

What do you think about this?

from metric4coref.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.