Add ability to change the http_status_code in Hoodoo::Errors about hoodoo HOT 5 CLOSED

If an errors collection is empty, it acquires the status code from the first item added.

I'm not sure you should be mutating the errors instance inline, but if you are, it'd be a question of removing the one error entry (which might empty the collection) then adding a new one (which if the collection was now empty should auto-set the status code for you).

from hoodoo.

The reason we are mutating here is because the errors instance could already have more than one error in it. So removing it then adding a new one might not be adding it to an empty array, which then wouldn't update the status code.

from hoodoo.

Now that I think about it one possible way to do it now is to dup the errors, modiy them, empty the Hoodoo:Errors#errors collection, then add all the new modified errors in.

from hoodoo.

I'd probably:

• Create a new Errors instance
• Iterate through the source Errors instance, transmogrifying entires if necessary
• Call add_precompiled_error on the new Errors instance to add the possibly-altered error entries back

Done. Actually it's probably even cleaner to iterate, then either add_precompiled_error for one you aren't modifying, or use add_error to add the thing or things you actually want for the case when you want to change an entry into something else. Code should be easier to read.

See also the source code for Errors#merge! in errors.rb.

from hoodoo.

I'm going to close this, I implemented this with public APIs here: https://github.com/LoyaltyNZ/service_purchase/pull/108

from hoodoo.