Generate SVG? about kjua HOT 18 CLOSED

I added a svg mode.

from kjua.

Crisp-mode was added

from kjua.

The new releases are still not tagged on GitHub. Anyway, I've updated my test (comparison) site and it works great!

from kjua.

I forked this repo and added SVG-rendering. It is published as kjua-svg on NPM. Feel free to try it out

from kjua.

source seems to be here: https://github.com/werthdavid/kjua

I'll take a look…

Some questions though:

1. Why not (consider to) contribute it back to upstream here? 😃
2. Did you keep/support the "crisp mode" in the SVG version, too?

from kjua.

Ah okay 2. is answered by the "limitations" sections in the Readme.

from kjua.

I didn’t make a PR since the owner of Kjua doesn’t seem to care. He’s not answering to issues or the other open PR and even private mails..

from kjua.

Anyway, it would be good to propose one. So you show interest at least and no one can blame you that you did not intend to contribute it back.

from kjua.

That’s right I’ll do that..

from kjua.

Awesome! I'll need to look into that, because this can solve rugk/offline-qr-code#188 for me… 😄 (don't mind the issue title)

from kjua.

I have not published this on NPM yet, still working on embedding text at least... do you need a release for your extension?

from kjua.

I can also just manually download/use the JS file, so no. 😄

from kjua.

Okay, actually a release would be nice. I use the file in dist usually.

from kjua.

Will do

from kjua.

[email protected]
(I am willingly breaking semver since I want it to be close to kjua. so kjua 0.6 will always be a kjua-svg 1.6)

from kjua.

If this lib is really not maintained, you could just continue maintaining/versioning it as usual.

BTW 1.6.1 release is not on GitHub yet: https://github.com/werthdavid/kjua (maybe just npm?)

from kjua.

Okay, I am testing how the new lib looks in rugk/qr-code-libs-test#2. What I've noticed so far as that the SVG version is bigger and does not add an automatic border? (still v1.6, so crisp does not work yet)

from kjua.

I’ve added svg.js in 1.6.2 to enable embedding of Label or Image on the SVG element. Couldn’t get it to work with plain JS, svg manipulation is a pain in the a**.

Is this a problem? Any better ideas?

from kjua.