Comments (11)
@dawbarton Thank you for the revisions. There are indeed a few mistakes, I will implement your corrections. The references to the figures and equations are indeed missing. I am unfamiliar with Markdown, so I wrote the paper on TeX and likely the \ref command does work on Markdown. I'll upload a corrected version of the paper to the repo. @fmeirinhos
from kramersmoyal.
Dear @dawbarton,
I have implemented you corrections (and asked whedon to generate a new paper.pdf).
https://github.com/openjournals/joss-papers/blob/joss.01693/joss.01693/10.21105.joss.01693.pdf
The indicated annotations you had where inserted.
There are two points I noticed and corrected simultaneously:
- The figure captions I had on my original TeX were never printed by whedon initially (given my lack of knowledge of Markdown). I have somehow found a way to introduce them in a table format. Would you be so kind to glance over the paper once more? (I'm not sure captions for figures are a standard at JOSS)
- I have come across a very relevant package for
R
that tackles similar issues of stochastic processes, that I feel should be cited in our paper, given the relevance of its content. It can calculate Kramers-Moyal coefficients in 1 and 2 dimensions (as far as I understood). It is referred to as [@Rinn2016] and the following was added: "There exists a library to retrieve Kramers--Moyal coefficents inR
[@rinn2016]."
(https://openresearchsoftware.metajnl.com/article/10.5334/jors.123/)
[the bib.file is therefore also updated]
@kthyng I believe as an editor this information is relevant for you as well.
Best regards,
Leonardo Rydin
@fmeirinhos
from kramersmoyal.
Hi @LRydin! Some fixed for your references:
- In bibtex, author names should be separated by "and". In particular, your entry for scikitlearn needs "and" between authors instead of commas. Also your entry for Lehnertz and others. You can see examples here: https://joss.readthedocs.io/en/latest/submitting.html#example-paper-and-bibliography
- Please also check the spacing around your references in the paper and whether they have parentheses or not. If you refer to them directly inline, they should not have parentheses. To have parentheses in your reference, use [@referencename] and to not have them, use @referencename.
from kramersmoyal.
Dear @kthyng,
I have corrected the bib file and respectively the paper according to the two points you just mentioned. Thank you.
Best,
Leonardo Rydin
@fmeirinhos
from kramersmoyal.
Hi @LRydin, great! Still have some changes:
- 3rd paragraph, need space before reference after "... jumps in data"
- 2 "and"s in your reference called "rinn2016".
Rest looks ok but I'll read it more carefully later.
from kramersmoyal.
It's helpful to reference the paper review issue from here too.
from kramersmoyal.
Hey @kthyng,
I will attend to these right away, thank you.
Best,
Leonardo Rydin
@fmeirinhos
P.S.: I'll refer to the paper review issue
from kramersmoyal.
As indicated, we corrected the above comments by @kthyng
Best,
Leonardo Rydin
@fmeirinhos
Referring the review issue
from kramersmoyal.
looking good!
from kramersmoyal.
@dawbarton Is this issue ready to be closed from your perspective?
from kramersmoyal.
Yes, looks good to me.
from kramersmoyal.
Related Issues (9)
- Errors in the readme [joss.01693] HOT 7
- TypeError raised by test HOT 2
- Community guidelines, code of conduct, issue and PR template HOT 3
- Clarifying normalization HOT 2
- misplaced issue
- multidimensional DFA HOT 2
- Bandwidth? HOT 2
- Help with Methodology (vectors' angles from Kramers-Moyal coefficients) HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kramersmoyal.