Giter VIP home page Giter VIP logo

Comments (10)

yymao avatar yymao commented on August 14, 2024

A SMF test with PRIMUS 2013 data is now available from the merged PR #51.

from descqa.

rmandelb avatar rmandelb commented on August 14, 2024

@janewman-pitt-edu @sschmidt23 @morriscb - was this test of the stellar mass function in DC2 intended for the photo-z working group?

I hope @yymao will correct me if I am wrong, but my understanding is that the test has been implemented currently without a validation criterion, so we just need a validation criterion to close this issue. Might PZ be able to supply a validation criterion? You can see the format of the test here:

https://portal.nersc.gov/project/lsst/descqa/v2/?run=2017-12-21_14&test=SMF_PRIMUS

it's implemented in redshift bins based on comparison with PRIMUS.

from descqa.

yymao avatar yymao commented on August 14, 2024

Yes, @rmandelb. This test is already implemented. We need a validation criterion. If the PZ WG would like to provide a different validation data set, we can do that too.

from descqa.

evevkovacs avatar evevkovacs commented on August 14, 2024

@rmandelb @janewman-pitt-edu @sschmidt23 This test was implemented in DESCQA1 and I ported it to DESCQA2 because it was such a basic test. I added the PRIMUS data for the higher redshifts. It wasn't formally requested by any WG to my knowledge.

from descqa.

janewman-pitt-edu avatar janewman-pitt-edu commented on August 14, 2024

No, PZ has little interest in the mass function. I think it was for LSS.

I would be wary of PRIMUS constraints as the sample is highly incomplete and has a relatively high catastrophic redshift error rate. Low-z constraints are almost certainly more useful (especially because they can probe below L*).

from descqa.

rmandelb avatar rmandelb commented on August 14, 2024

@slosar - can you confirm whether LSS would like to have a validation test of the stellar mass function for DC2?

If no, then I think we can safely dispense with this validation test for DC2 since it's not needed to support any working group's goals. If yes, then we need to define validation criteria etc.

from descqa.

janewman-pitt-edu avatar janewman-pitt-edu commented on August 14, 2024

Just a note -- if we don't do a stellar mass constraint (and I'd be happy not to, as unlike magnitudes stellar masses are not directly observable but rather rely on models/assumptions to infer), we do want to have some sort of dN/dmag or dN/dz test to make sure the numbers of objects are sane.

from descqa.

rmandelb avatar rmandelb commented on August 14, 2024

Yes, I agree. I don't believe there is any thought that the dN/dz or dN/dmag test will disappear (despite the fact that the exact form of these is still being finalized).

from descqa.

yymao avatar yymao commented on August 14, 2024

Given that this is not a required test and it is already implemented (though without validation criteria). We can probably close this issue. Do you agree @rmandelb?

from descqa.

rmandelb avatar rmandelb commented on August 14, 2024

@yymao - I agree. People can look at the plot, and that's it - we are done. Thank you!

from descqa.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.