Comments (1)
Hi krisgry,
I finally had the time to look at this properly. So I did the following tests:
-
Run x8-02 in Simulation profile (using LOS and Height controllers instead of ArduTracker). Result: Issue not reproduced.
-
Run x8-02 in AP-SIL profile (using ArduTracker) with "Time Of Arrival Factor" = 1.0 and "Seconds before Waypoint" = 2.0 (from Ardupilot Task). Result: Issue reproduced.
-
Run x8-02 in AP-SIL profile (using ArduTracker) with "Time Of Arrival Factor" = 2.0 and "Seconds before Waypoint" = 2.0 (from Ardupilot Task). Result: Issue not reproduced.
This showed me that this issue only happens if "Time Of Arrival Factor" < "Seconds before Waypoint". It turns out that when this condition is true, sometimes the Ardupilot Task will set the flag FL_NEAR before the Path Controller sets m_ts.nearby (and therefore FL_NEAR). This will make the the GoTo maneuver signal completion and the Plan Engine proceed with the following maneuver on the plan (thus dispatching the following DesiredPath). And this is how the PathController will enter the condition you pointed out.
Regarding actions, I don't consider this as a bug on either of the tasks (neither PathController nor the Ardupilot), for the following reasons:
-
Both tasks don't depend on each other and can work properly if the other one is not being used. You can run the ArduTracker and have path controller disabled and the other way around.
-
As long as the condition "Time Of Arrival Factor" < "Seconds before Waypoint" isn't true, this doesn't happen. I can add in the description of the parameter "Seconds before Waypoint" that it should be smaller then "Time Of Arrival Factor" (or even a warning).
-
If the user doesn't respect the condition that guarantees that this issue won't happen, it's not critical in any way I can think of.
Let me know what you think about this, so I know if I can close this issue or not.
from dune.
Related Issues (20)
- Sporadic segmentation fault at startup HOT 1
- PathController: Get next maneuver HOT 4
- World magnetic model update (WMM2015v2) HOT 1
- Fix AppVeyor build HOT 2
- Unnecessary check of isActive in Maneuvers/Maneuver consumes
- Ardupilot-task: Bug in down velocity HOT 3
- Ardupilot-task: Keep time in imu dispatch
- Utils fails to create an MD5 sum on RHEL for the IMC Generator
- Segfault in Seatrac Task because ticket pointer is not initialized.
- Update CDC3 Simulator to support sending Target-of-Interest messages
- Windows compilation HOT 2
- Add flags to reduce build size and compilation time HOT 1
- DUNE/Hardware/LUCL: Possible buffer overflow
- Dune runs on beaglebone black. HOT 1
- imc_blob.py: 'ElementTree' object has no attribute 'getiterator' HOT 1
- No new PRs
- Dune build in Windows doesn't work
- Error building Dune on Windows CMake with VS2019 HOT 1
- Math::average may overflow
- Setting LBL Measurement Noise Index overflow HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dune.