Comments (7)
hi you could just ask for commit access.
from luajit-test-cleanup.
True. However as a contributor I am hoping to use the Fork and Pull model and this requires a maintainer to engage with me after I open a pull request and make sure the changes are moving the repo in the right direction. Is someone(s) taking that role on this repo?
from luajit-test-cleanup.
Several people have that ability. Just do your thing and it will get handled. The main problem we faced early on was over protective handling of the repo, and thus nothing has happened. Make your changes, and make your pull request.
from luajit-test-cleanup.
And keep in mind, Mike said in the beginning, all history will likely be lost once this test report is merged into something else, like the main LuaJIT repo. So, branching, and pull requests and the like are more of a personal style and cleanliness/safety thing than a strict requirement.
from luajit-test-cleanup.
@Wiladams Groovy. So here is how I see myself cooperating with other testniks:
- I maintain the branch lukego/luajit-test-cleanup#branchmarks. This is a public branch with a stable history that is safe to pull from. I have made this a protected branch on Github to avoid even accidental force pushes.
- The purpose of the
branchmarks
branch is to provide the test suite for CI. My job as maintainer is to pull improvements to the test suite but make sure they are compatible with the CI before I push them. The invariant is thatbranchmarks
always runs the code that is live on CI. - I would like to have one or more branches to pull improvements from e.g. the master branch on this repo. However I would need to know that these branches will never be force pushed (see link above about public branches). So it would help me if there were a known policy on whether the master branch here has a stable history (e.g. perhaps you guys could consider making it a protected branch too).
- I will probably make my test suite changes on topic branches and PR them here for discussion. You guys could decide whether to review/merge/reject them individually (separately for each topic branch) or collectively (pull the whole
branchmarks
branch).
How does that sound?
from luajit-test-cleanup.
(and yes I understand that we may need to completely replace the workflow in the future e.g. if this code is all moved into the luajit repo, etc, but we can deal with that when it happens.)
from luajit-test-cleanup.
What's the current state of this repo?
from luajit-test-cleanup.
Related Issues (11)
- Commit access HOT 16
- CI for benchmarks online HOT 13
- Test 366 failing on LuaJIT v2.1 HOT 2
- Test 219 failing on luajit trunk HOT 1
- Consistent naming and grouping scheme HOT 3
- Test 220 failing on luajit v2.1 HOT 2
- Testing framework HOT 27
- Convert, split up and reorganize tests HOT 6
- Using a declarative data-driven approach to organize the test suite (like TestML) HOT 14
- Add Lua 5.1/5.2 test suites HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from luajit-test-cleanup.