Best way to implement something like an abstract base class? about lua-language-server HOT 3 OPEN

No you didn't get anything wrong afaik. I wish this was supported too.

However, it now triggers injected-field on all user-defined values not defined in the base class like the myHelperFunction method :(

You (or the downstream user) could always just manually ignore those errors I suppose (using ---@diagnostic), and I think those funcs/methods would still get applied to the derived class type.

Also, FWIW, there's this lol:

---@class MyImpl: Base
local foo = New("MyImpl")

;(--[[@as Base]]foo).OnClick = function(self, x, y)

end

function foo:myHelperFunction()
end

...but that would have to be done manually for each overridden method, and this LSP doesn't necessarily warn you or make it obvious when you are doing so (overriding).

Another hack that might work (in some sense?):

local foo = New {
    OnClick = function(self, x, y)

    end,

    myHelperFunction = function()

    end
}

but then users would be required to call New() like this every single time...

Hopefully this gets fixed or improved if/when the LSP is refactored (#2366).

from lua-language-server.

FWIW I implemented this as a plugin for our stuff that just injects a @Class annotation together with a lot of @field annotations: https://github.com/DeadlyBossMods/LuaLS-Config/blob/main/DBM-Plugin.lua

from lua-language-server.

I'm looking through your solution, @emmericp and I can't wrap my head around what exactly you've done to accomplish this.

from lua-language-server.