Giter VIP home page Giter VIP logo

Comments (4)

lucaong avatar lucaong commented on May 18, 2024 1

I will create a release avoiding the destructuring of those two fields. In general, I wouldn't change the library to accommodate build tools, as the build tools themselves can be configured, and there are too many possible setups in the wild to account for all of them. In this case though, it makes sense, as it is quite an established convention that variables starting with _ are private, or unused variables.

In general, the index serialization code is one feature that I want to change in the near future. The current serialization is too tightly bound to a specific inverted index implementation, and could hinder further improvements of MiniSearch that have to modify the data structure.

from minisearch.

janwirth avatar janwirth commented on May 18, 2024

Maybe using _ as suffix a rather than prefix would do it?

from minisearch.

lucaong avatar lucaong commented on May 18, 2024

I will close this issue, as it is fixed by this commit and will be part of the next release.

from minisearch.

lucaong avatar lucaong commented on May 18, 2024

Released as part of v2.2.2

from minisearch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.