Avoid space insertion when inserting licence about pre-commit-hooks HOT 7 CLOSED

IMHO, if the user specifies an empty comment-style, then not adding the space seems the right thing to do (even if that changes the behavior for users that have set an empty comment-style).
That alone is a solution for me.

Maybe I'll add the new option to disable adding the space, but then this implies more work (tests), so I am not sure I am going to do that.

from pre-commit-hooks.

Changed --no-space proposal to --no-space-in-comment-prefix as requested in #31 and created PR #33 .

from pre-commit-hooks.

Because we always introduce a whitespace character between the comment prefix and the license lines, this is indeed not currently possible: https://github.com/Lucas-C/pre-commit-hooks/blob/master/pre_commit_hooks/insert_license.py#L76

The best you can achieve is this I think:

# #############################################################################
# Copyright (C) 2017 Teela O'Malley
#
# Licensed under the Apache License, Version 2.0 (the "License");
# #############################################################################

import sys
sys.stdout.write("FOO")

With this license file:

#############################################################################
Copyright (C) 2017 Teela O'Malley

Licensed under the Apache License, Version 2.0 (the "License");
#############################################################################

and --comment-style="#"

from pre-commit-hooks.

@Lucas-C Thanks for responding.

This issue is all about the added space.

I find --comment-style '' somewhat better, because it adds a space at the start, I'ld suggest that an empty comment-style would not add anything to the licence file contents.

from pre-commit-hooks.

Pull Requests are welcome 😊

from pre-commit-hooks.

Good, they not always are ...

So you're good with an empty comment-style resulting in no spaces added?

Maybe I'll throw in an option to disable the addition of the space as well - is --no-space ok for you as an option?

from pre-commit-hooks.

So you're good with an empty comment-style resulting in no spaces added?

Yes, sounds good.
We just need to check how the tests behave after implementing this: I won't accept a PR that changes this hook behaviour for existing users.

Maybe I'll throw in an option to disable the addition of the space as well - is --no-space ok for you as an option?

Could you clarify if your plan is to change this hook default behaviour, or if you plan to add an extra option for more control over it?

from pre-commit-hooks.