Giter VIP home page Giter VIP logo

Comments (12)

LucasPilla avatar LucasPilla commented on July 20, 2024

Currently the program does not handle errors, so if you insert some non digit caracters in the Size box it will broke! If you did all right you must have found some exception, message me again. Thanks for reporting this issue.

from sorting-algorithms-visualizer.

LucasPilla avatar LucasPilla commented on July 20, 2024

I would appreciate your feedback about the program, and if you intend to help as well!

from sorting-algorithms-visualizer.

Mikhaylov-yv avatar Mikhaylov-yv commented on July 20, 2024

Yes, I'm ready to help.

I made a clone of your project. And crunched main.py. But I did not understand what parameters need to be entered for the program to work.
Or should I add an algorithm file to the project?

from sorting-algorithms-visualizer.

LucasPilla avatar LucasPilla commented on July 20, 2024

You managed to open the program with the size, delay, algorithm and play buttom?, similar to the gif in README.
If you did it you just have to insert valid values, e.g. 450 in size, 0 in delay, Mergesort in algorithm and press the play buttom

All you have to insert are inside the program, for inicialize it you just need to execute main.py

from sorting-algorithms-visualizer.

Mikhaylov-yv avatar Mikhaylov-yv commented on July 20, 2024

I'm sorry everything works!
Let me add the default parameters.
This will make it easier to understand how the program works.

from sorting-algorithms-visualizer.

LucasPilla avatar LucasPilla commented on July 20, 2024

Sure, I will asign this issue to you! If you manage a way to handle this errors, so when a user forgets this parameters or insert them wrong the program does not broke i would appreciate as well.

from sorting-algorithms-visualizer.

Mikhaylov-yv avatar Mikhaylov-yv commented on July 20, 2024

I don't understand why such a diff turns out.
It looks like this to me:
dif

from sorting-algorithms-visualizer.

LucasPilla avatar LucasPilla commented on July 20, 2024

Are you up to change the code for handle possible errors?

from sorting-algorithms-visualizer.

Mikhaylov-yv avatar Mikhaylov-yv commented on July 20, 2024

Yes of course

from sorting-algorithms-visualizer.

LucasPilla avatar LucasPilla commented on July 20, 2024

Its working well, but it would be more efficient if the default values were defined just once outside the loop, right? Its not necessary to keep verifying and neither create a bool variable.

from sorting-algorithms-visualizer.

Mikhaylov-yv avatar Mikhaylov-yv commented on July 20, 2024

Oh sure. I'll fix it now.

from sorting-algorithms-visualizer.

LucasPilla avatar LucasPilla commented on July 20, 2024

I will close this issue and merge the pull request that you add default values

from sorting-algorithms-visualizer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.