Docker-tc fails with multiple containers in same network about docker-tc HOT 11 OPEN

@lukaszlach I believe I already have a fix for it and I have already forked the repo. I'll try to fix it myself and if you like the solution I can make a pull request ;)

from docker-tc.

Confirmed. If multiple docker containers are connected to the same bridge network, then the current workflow will fail to work.

Docker Container → Docker Network ID → Linux Network Interface

For a single bridge network, each container that links to it will have a veth interface. So the bash script will return multiple items for NETWORK_INTERFACE_NAME.

from docker-tc.

It seems that matching Docker Container ID with veth is not that trivial. There are some open-sourced scripts doing this: https://github.com/micahculpepper/dockerveth.

from docker-tc.

I have a fix for it already in my fork. I just need to get my branch and commits cleaned up and I'll make a pull request ;)

from docker-tc.

Thank you. I saw your implementation. But https://github.com/micahculpepper/dockerveth points out:

When I'm tracking down a problem in production, I'll typically wind up on a Docker server and see that my problems are coming from one veth interface or another. But making the leap from veth ID to container ID can be tricky. Folks on the internet suggest that you run some commands in bash inside your container, which is OK if your container has bash. Sometimes I'm working on Go containers that are just a single binary and don't even have a command-line interface to attach to.

I wish that I could make the leap from container ID to veth ID without provoking sudo privileges. But it seems that it is hard to do so with out sudo.

from docker-tc.

Hello folks, I am interested in using this tool too and was wondering if there was a chance for a release with the fix @Silcet? Thanks :)

from docker-tc.

@Lawouach I just need to clean my commits to make a branch for the pull request. I'll try to get it done today. Sorry for the wait ;)

from docker-tc.

No worries. Always appreciated to have feedback :)

from docker-tc.

Ok, I have just made the pull request #5 . @Lawouach maybe you could try to test it to see if it feets your needs?

from docker-tc.

Awesome. Your branch seems to be working just fine @Silcet!

from docker-tc.

Can I ask you to confirm that the #5 just merged resolves this issue?
The updated Docker image has also been released on Docker Hub.

from docker-tc.