Comments (7)
Hey, it should!
I don't have access to a windows machine, but it's just react-hot-loader
and webpack-dev-server
. I've wrapped RHL to get rid of the 2kB file it adds in production build, but if you can test this for me that'd be great:
// import { HMR } from '@pwa/preset-react';
import { hot } from 'react-hot-loader';
// export default HMR(App, module);
export default hot(module)(App)
Thanks!
from pwa.
Hmm, that doesn't work for me either.
I've never used react-hot-loader
and webpack-dev-server
so I'm not quite sure how to debug them.
p.s. It's probably worth doing some testing on Windows given there's far more people using Windows compared to MacOS or Linux :D
from pwa.
I'll see what I can do over the weekend.
Definitely agree re: having Windows access
from pwa.
hmm, interesting. I just started a React project with the vanilla CSS option and HMR seem to be working fine on my surface device in FF, Edge and Chrome.
Are you using WSL @Daniel15 ? I don't have that so couldn't test if it works ok.
from pwa.
tried getting a machine a few months ago, but the TLDR of it all is that it got stolen from UPS
Ahh, that sucks :( Sorry to hear. I hope you resolve things soon!
I just started a React project with the vanilla CSS option and HMR seem to be working fine on my surface device in FF, Edge and Chrome.
Hmm, interesting, I wonder if something weird is happening in my environment.
Are you using WSL @Daniel15 ?
No, just 'native' Windows command line.
I'm editing src\components\App\index.js
.
from pwa.
Thanks for looking into this @zouhir
TBH, I'm not really sure what could be happening @Daniel15 :/ As mentioned, there are very few actors at play. I also have coworkers who've been using this setup for a while (at work) on CMD, WSL, and true Ubuntu.
Hopefully someone can offer some expert-level insight here, as I've just strung together existing tools
from pwa.
Hey so I finally got my hands on a Windows machine & couldn't for the life of me replicate this issue
If you, or anyone(!), still sees it, please let me know
Thank you for the ticket!
from pwa.
Related Issues (20)
- Irrelevant question HOT 1
- Export to relative paths? HOT 6
- Creating a project with just 'less' preprocessor throws an error HOT 1
- PWA command not found on local install HOT 2
- Add push notifications and things mentioned in here
- How do I deloy on a heroku server? HOT 2
- how could I contribute translation for this project? HOT 2
- Service Worker
- Feature Request - Init into existing Project HOT 1
- React Installed brand new, not working straight up. HOT 5
- Config for supplying own service worker file
- npm i missing from docs
- Help, how to remove .svelte file from browser source HOT 3
- Duplicated App in svelte production HOT 2
- Create sub-folder in pages folder [Svelte] HOT 2
- @pwa/plugin-typescript is not published HOT 2
- Custom postcss webpack style rules missing with pwa.config.js HOT 8
- Handle LauncherError exception HOT 4
- When you say "WIP" what does that mean? HOT 2
- pnpm install
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pwa.