Comments (6)
Hey, we can only run Critters within the build process. There's no other place to put it since it's a webpack plugin.
Were you seeing an issue? Why do you think it should be elsewhere?
from pwa.
Hey,
What about using prerender-loader to produce the HTML files ? Would it be a good idea?
Furthermore, the critters github page says:
Critters' design makes it a good fit when inlining critical CSS for prerendered/SSR'd Single Page Applications. It was developed to be an excellent compliment to prerender-loader, combining to dramatically improve first paint time for most Single Page Applications.
from pwa.
You can use prerender-loader
instead of pwa export
, though I don't know why you would since it's the same functionality. You'd have to configure it manually inside your pwa.config.js
which would be easy.
Critters already works, as is, with pwa build
and pwa export
. This is why it's included as an official plugin :) Are you guys having issues with it?
You can verify it's working by viewing the source of your built pages. A lot of CSS will be inlined in the <head>
of your page(s).
from pwa.
@lukeed it seems the css generated by critters is not all the critical css. i will try to make a minimal example to reproduce it.
from pwa.
Great, thanks! If that's the case, it's likely an issue with Critters itself, but I'm happy to take a look & pass it along to Critters if needed.
from pwa.
Hey,
Thanks for the answer :) I personally don't have any issue with the pwa export
functionality. I just had the impression that the export was done more or less manually (with the chrome-launcher). Since a webpack plugin can achieve the same result, I was just wondering if it would be a good idea to use it instead.
from pwa.
Related Issues (20)
- Irrelevant question HOT 1
- Export to relative paths? HOT 6
- Creating a project with just 'less' preprocessor throws an error HOT 1
- PWA command not found on local install HOT 2
- Add push notifications and things mentioned in here
- How do I deloy on a heroku server? HOT 2
- how could I contribute translation for this project? HOT 2
- Service Worker
- Feature Request - Init into existing Project HOT 1
- React Installed brand new, not working straight up. HOT 5
- Config for supplying own service worker file
- npm i missing from docs
- Help, how to remove .svelte file from browser source HOT 3
- Duplicated App in svelte production HOT 2
- Create sub-folder in pages folder [Svelte] HOT 2
- @pwa/plugin-typescript is not published HOT 2
- Custom postcss webpack style rules missing with pwa.config.js HOT 8
- Handle LauncherError exception HOT 4
- When you say "WIP" what does that mean? HOT 2
- pnpm install
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pwa.