Fetch should consider document.baseURI about csz HOT 6 OPEN

This sounds doable.. I haven't used <base href=/PATH/ > in a while. Is there a way to pick this up in Javascript an if so is it just a case of prefixing the urls with this variable?

from csz.

You can use document.baseURI for get the url with protocol and domain or new URL(document.baseURI).pathname in order to get the path only. You should take care if the baseURI finished in / to avoid having // in the URL.

from csz.

Awesome, do you fancy making a PR for this?

from csz.

I was thinking about it and I think that it is better to add support for relative paths (path that starts with ./) so fetch uses document.baseURI automatically.

Basically from this

const isExternalStyleSheet = key => /^(\/|https?:\/\/)/.test(key.trim());

to

const isExternalStyleSheet = key => /^(\/|\.\/|https?:\/\/)/.test(key.trim());

What do you think? I think it is a better solution.

from csz.

This certainly sounds like a better option! A much less involved change.. have you tested it and does it work for your use case and not break others?

(sincere apologies for no tests)

from csz.

I test it in my project and it works well but I don't test it in other cases. I think it should not break anything unless you use a class name that starts with / something like ./WHATEVER (I think that it is not normal but a valid css class name). Maybe the regex has to test about the file extensión to avoid conflicts with some rare class names. The problem with this last approach is that if you serve files behind a server without a file extension in the url (like https://MY_URL/styles/App) it will failed. The problem with the rare class names can be avoid by the user changing

css`
  ./NAME { ...properties }
`

to

css`
  & {
    ./NAME { ...properties }
  }
`

What do you think?

from csz.