Update item not working about laracart HOT 7 CLOSED

You can call \LaraCart::update(), but that seems to be bug and should be saved directly after you call updateItem. Will have to look to see whats wrong.

Also you should be able todo

item->title= 'asd';

Are you saying that one doens't seem to update either?

from laracart.

yes.

from laracart.

 /**
     * Updates an items attributes
     *
     * @param $itemHash
     * @param $key
     * @param $value
     *
     * @return CartItem
     *
     * @throws Exceptions\InvalidPrice
     * @throws Exceptions\InvalidQuantity
     */
    public function updateItem($itemHash, $key, $value)
    {
        if (empty($item = $this->getItem($itemHash)) === false) {
            $item->$key = $value;
        }
        $item->generateHash();
        $this->update();
        return $item;
    }

Should update appropriately. Your not doing a dd or a dump on the page are you? dd for testing this are you ? If so it will not write to sessions when you do that.

from laracart.

I will test this out ASAP, thanks for brining it to my attention.

from laracart.

Hi Luke, I solved it.

After looking at your code - I like the cleanliness and comments, wish everybody would code like that - I found that there are new configuration options which I didn't publish. cross_devices broke my neck here. Mainly my mistake, an isset would circumvent this but then I should be smarter.

Thanks for your quick reply.

from laracart.

Ill add that check! Thanks for debugging , feel free to make any PR's as well~

from laracart.

I made the fix for other config options, but not for cross devices, the default value should come into check and provide false. So not sure why that would cause issues.

from laracart.