Comments (2)
sidkshatriya
commented on August 23, 2024
The PHP dom html parser and the mastermind html5 output serializer don't play nice together when you have tags nested within <noscript> in <head>.
Along with the PHP notice, an empty <noscript> tag was outputted in <head> . In other words this was not a totally benign notice but a small bug that should be resolved now.
This is a subtle issue and a workaround has been implemented in the above PR.
A ticket has been filed in the mastermind library in the meanwhile to see if there is a better workaround than the current workaround: at Masterminds/html5-php#98
TL;DR: @Mdrummond @mtift You should not see this notice anymore.
from amp-library.
sidkshatriya
commented on August 23, 2024
I've implemented a much more efficient workaround for the <noscript> issue by implementing a new Pass (Lullabot\AMP\Pass\NoscriptTagWorkaroundPass ).
This avoids re-parsing of the whole page html (which is great!). See above commit for details.
from amp-library.
Related Issues (20)
- standard amp-selector is being removed HOT 1
- TwitterTransformPass | Invalid HTML cause fatal error HOT 2
- is this repo dead? HOT 2
- inline style removed from div block HOT 3
- Not Work Tag <picture> HOT 1
- Error "The script tag for amp-user-notification is likely included twice in the page". Circular dependency in validator-generated.php
- Support for new masterminds/html5 v2.7.0
- Inline css for table is removed
- support of PHP 7.4
- Convert from Instagram TV post HOT 1
- DISALLOWED_TAG on amp-google-document-embed HOT 2
- Signed exchange issues
- Laravel 8 support
- Set data-locale for FacebookNonIframeTransformPass
- Local image URL detection loses query arguments
- <amp-accordion> should allow expand-single-section attribute.
- After converting to amp html, amp-script component is discarded from the template
- Not working with php8.1.5 HOT 2
- Rename `master` branch to `main`
- Deprecated: Using ${var} in strings is deprecated, use {$var} instead with PHP 8.2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from amp-library.