Issue duckdb conversion about lumibot HOT 10 CLOSED

from lumibot.

 self.get_historical_prices(self.base, 50, 'day', quote=self.quote).df

Was trying to backtest on binance and ccxt.

from lumibot.

This is a question for @mrchaos , who created this feature. @mrchaos any ideas how to fix this?

I also don't think we have documentation for this yet

from lumibot.

As an aside: it seems like we should be using a different type for duckdb. Crypto can have both very large and very small values, so I don't think double is the appropriate data type. I think can either use something like bigint and move the decimals, or save it as a string.

@Daniel-ltw feel free to submit a pull request if you make a fix

from lumibot.

Drop a breakpoint before the insert and the culprit is the volume column value.

Will test running it with bigint now and see how that works.
If this goes well, will put in a pr for it.

from lumibot.

from lumibot.

Yup. DuckDB allows us to use decimal for the columns.

con.execute("""CREATE TABLE IF NOT EXISTS candles (
                            datetime DATETIME,
                            open DECIMAL, high DECIMAL, low DECIMAL, close DECIMAL, volume DECIMAL, missing INTEGER)""")

Just need to update line 230-232 to the above.

Will drop in a PR for this small change.

The rest of the prices were in float but was also throwing errors, which cause the trade_cost calculation in the backtesting_broker to fail. The above change should address this issue.

from lumibot.

PR created. #416

from lumibot.

from lumibot.

Has been merged. Will close this issue for now.

from lumibot.