Giter VIP home page Giter VIP logo

Comments (6)

MarkY-LunarG avatar MarkY-LunarG commented on June 24, 2024

This seems like a preference thing, to me. But I'll let @dustin-lunarg weigh in.

from gfxreconstruct.

andrew-lunarg avatar andrew-lunarg commented on June 24, 2024

This still happens on Linux even though stderr is the default, and is set in settings at the point void Log::LogMessage() is entered. There is a bunch if platform #ifdefing in that function which may be hiding a bug.

Since toascii has a --stdout output option, this is definitely a bug and not a matter of taste for that tool. Logging to stdout when also outputting JSON Lines to stdout makes the mainstream JSON tool jq choke on our output and kill the pipeline that it is in.

@bradgrantham-lunarg Can we raise the priority on this?

from gfxreconstruct.

bradgrantham-lunarg avatar bradgrantham-lunarg commented on June 24, 2024

Can we solve the jq problem temporarily with grep -v '[gfxrecon]' between the toascii output and jq?

from gfxreconstruct.

andrew-lunarg avatar andrew-lunarg commented on June 24, 2024

Can we solve the jq problem temporarily with grep -v '[gfxrecon]' between the toascii output and jq?

Yes for sure. Good point.

from gfxreconstruct.

lunarpapillo avatar lunarpapillo commented on June 24, 2024

Proper function while pipelined is more important than stdout/stderr. Sending all logging to stderr (and documenting such) is acceptable (though this will require minor changes in CI, which currently look for important information - e.g. FPS, for performance tests - in stdout.)

If we're thinking fancy, new switches --log-stdout, --log-stderr, --log-stdout-stderr (INFO and less go to stdout, WARN and higher to stderr), and --log-none could be added to allow the user to direct log output as needed. (Right now, if you specify --log-file, does logging go to just the file, or to the file and stdout?)

But there may be confusion here, if a user using gfxrecon-convert in a pipeline doesn't realize that they probably want --log-stderr or --log-none... and we probably don't want different tools to have different defaults. So maybe just logging to stderr is better.

I'll leave it for the team to decide.

from gfxreconstruct.

andrew-lunarg avatar andrew-lunarg commented on June 24, 2024

But there may be confusion here, if a user using gfxrecon-convert in a pipeline doesn't realize that they probably want --log-stderr or --log-none... and we probably don't want different tools to have different defaults. So maybe just logging to stderr is better.

👍

from gfxreconstruct.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.