Comments (6)
This seems like a preference thing, to me. But I'll let @dustin-lunarg weigh in.
from gfxreconstruct.
This still happens on Linux even though stderr is the default, and is set in settings at the point void Log::LogMessage()
is entered. There is a bunch if platform #ifdef
ing in that function which may be hiding a bug.
Since toascii has a --stdout
output option, this is definitely a bug and not a matter of taste for that tool. Logging to stdout when also outputting JSON Lines to stdout makes the mainstream JSON tool jq
choke on our output and kill the pipeline that it is in.
@bradgrantham-lunarg Can we raise the priority on this?
from gfxreconstruct.
Can we solve the jq
problem temporarily with grep -v '[gfxrecon]'
between the toascii output and jq?
from gfxreconstruct.
Can we solve the
jq
problem temporarily withgrep -v '[gfxrecon]'
between the toascii output and jq?
Yes for sure. Good point.
from gfxreconstruct.
Proper function while pipelined is more important than stdout/stderr
. Sending all logging to stderr
(and documenting such) is acceptable (though this will require minor changes in CI, which currently look for important information - e.g. FPS, for performance tests - in stdout
.)
If we're thinking fancy, new switches --log-stdout
, --log-stderr
, --log-stdout-stderr
(INFO
and less go to stdout
, WARN
and higher to stderr
), and --log-none
could be added to allow the user to direct log output as needed. (Right now, if you specify --log-file
, does logging go to just the file, or to the file and stdout
?)
But there may be confusion here, if a user using gfxrecon-convert
in a pipeline doesn't realize that they probably want --log-stderr
or --log-none
... and we probably don't want different tools to have different defaults. So maybe just logging to stderr
is better.
I'll leave it for the team to decide.
from gfxreconstruct.
But there may be confusion here, if a user using
gfxrecon-convert
in a pipeline doesn't realize that they probably want--log-stderr
or--log-none
... and we probably don't want different tools to have different defaults. So maybe just logging tostderr
is better.
👍
from gfxreconstruct.
Related Issues (20)
- VK_EXT_frame_boundary not enabled during replay when --offscreen-swapchain-frame-boundary is enabled HOT 2
- Virtual swapchain and screenshot features are incompatible with protected-capable device queues HOT 1
- [capture] Crash in Sascha's geometry shader sample HOT 8
- Add Android-specific hints and tips to HOWTO_android.md
- Correct typo in HOWTO_android.md HOT 1
- --api <api> command line option of gfxrecon-replay.exe
- Handle use of AHB on Android without QueuePresent with FrameBoundary as frame HOT 1
- fullscreenexclusive causes inconsistent replay failure
- Trimming shaderobjects trace causes replay failure
- Linux custom path installation is somewhat broken
- Add macOS entry to Release Packages GitHub Action
- Ensure GFXR builds for macOS x86_64 HOT 4
- Sign resulting DSOs so they can be loaded into signed apps like vkcube shipped with SDK HOT 1
- Add macOS entry to BUILD.md
- Add macOS entry to README.md HOT 1
- Put static libraries for compressors for ARM and x86 macOS in external/precompiled
- [capture] Why capture failed with hwui=skiavk? HOT 4
- ray-tracing captures are not tracked correctly HOT 1
- Support --fwo(--force-windowed-origin) on xcb, xlib, wayland and metal
- Support --fw(--force-windowed) on Vulkan
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gfxreconstruct.