Giter VIP home page Giter VIP logo

Comments (5)

jaredo avatar jaredo commented on August 30, 2024

PS. I just tried on octopus-0.1.1-alpha and it appears to still be there.

from octopus.

dancooke avatar dancooke commented on August 30, 2024

Hi Jared!

Many thanks for flagging this. I've found the problem! It's because the reference genome hg19 contains a mixture of lower & upper case bases while the reads are upper case only. Octopus was using the raw input, and considers mixed case versions of the same base as being distinct, causing high quality candidate variants at almost every position!

I've added sequence capitalisation transforms to both reference and read sequences. They can be turned off with the command line options --disable-reference-base-capitalisation and --disable-read-base-capitalisation respectively. The patch is available in release 0.1.2-alpha. The sample you posted now runs in about 5 minutes on my machine and in less than 2 minutes with --fast enabled. I'd also recommend taking a look at the command --threads if you have multiple cores available.

I'm also a bit concerned by the spurious message Not a BGZF file: test.vcf.gz you're getting. Does this appear every time you try to run octopus? I'd be grateful if you'd consider making a new issue detailing this.

Best wishes,

Dan

from octopus.

gerton avatar gerton commented on August 30, 2024

Hi Dan,

Good find! However, I would consider removing the new options —disable-reference-base-capitalisation and likewise for reads. I see no situation where you want to consider upper vs. lower case to be non-matching.

How do you treat Ns in the reads? In Stampy I set the quality to 0 to effectively make N match anything. (And for the reference I set it to G. One has to do something…)

Stuck in Copenhagen — flight delayed. Having fun implementing a bit more of the BWT algorithm (in the company of a Carlsberg..!)

BW
Gerton

On 14 Oct 2016, at 20:03, Daniel Cooke <[email protected] mailto:[email protected]> wrote:

Hi!

Many thanks for flagging this. I've found the problem! It's because the reference genome hg19 contains a mixture of lower & upper case bases while the reads are upper case only. Octopus was using the raw input, and considers mixed case versions of the same base as being distinct, causing high quality candidate variants at almost every position!

I've added sequence capitalisation transforms to both reference and read sequences. They can be turned off with the command line options --disable-reference-base-capitalisation and --disable-read-base-capitalisation respectively. The patch is available in release 0.1.2-alpha. The sample you posted now runs in about 5 minutes on my machine and in less than 2 minutes with --fast enabled. I'd also recommend taking a look at the command --threads if you have multiple cores available.

I'm also a bit concerned by the spurious message Not a BGZF file: test.vcf.gz you're getting. Does this appear every time you try to run octopus? I'd be grateful if you'd consider making a new issue detailing this.

Best wishes,

Dan


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub #4 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AD3zPjHX4RqDs5MVnzncO0whzpBeEtbHks5qz8QNgaJpZM4KXB3U.

from octopus.

dancooke avatar dancooke commented on August 30, 2024

Hi Gerton,

Yes I think you're right, I actually just read the mixed-case is only intended to mark low complexity regions. I'll remove them from the next release.

The raw cigar generator won't propose candidate base substitutions where either the reference or read base is N. Indels are allowed to contain Ns however. The local reassembler ignores any read k-mer with an N, creating a break in the k-mer path, but doesn't throw away the entire read. Reference sequence containing Ns is not allowed by the assembler as it requires a single contiguous path. Unfortunately this means the entire active region (~1000bp) won't be assembled.

I'll expect a flurry of commits!

Best,
Dan

from octopus.

jaredo avatar jaredo commented on August 30, 2024

Hi guys,

Thanks for the fast response. I can confirm this is resolved (takes 3 minutes on my AMI).

I am still getting this Not a BGZF file and will raise another issue once/if I can confirm it is not something weird to do with my environment.

Running on some full WGS data now - very excited to see the results!

from octopus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.