Reader parses '#' as nothing instead of returning error about lurk-rs HOT 5 CLOSED

This test doesn't fail anymore (it does give an error, but probably not the type we want). However just evaling "#" in the repl doesn't return an error and it sounds like it should.

A larger issue here is that the parser module uses Option where it should be using Result. I'm going to try to fix this along with #146 , with the general goal being "bad user input at the repl should not cause a panic". There are lots of places where we panic due to bad user input (via unwrap, assert, or explicit panic). I'll try to hunt down as many of these as possible and have them return Results. Panic should be only when we know there's a bug in the program somewhere.

@porcuquine you can assign this to me as well.

from lurk-rs.

That sounds right, but just bear in mind that as currently constructed, many of the reader's helper functions do also need to return Option (in some form). So a fix that replaces those with Result won't be right. They may need to become Result<Option<…>>.

from lurk-rs.

With PR #150 it looks like this:

> (cons # "")
Read error: Parser("Could not read character")

from lurk-rs.

@arthurpaulino do we have a test for this one?

from lurk-rs.

I don't think so. I tested it manually.

We can mark this one as good first issue and add a test for it later

from lurk-rs.