Double-click to launch a game fails in Icon View if... about lutris HOT 9 CLOSED

Can you reproduce this?
It's a bug or bad design inherent to GTK (rather a bug since the TreeView doesn't have the issue). I have the same behavior with this example browser.

from lutris.

Yup, able to reproduce. If I put a couple of print statements in the signals, in can see that the on_selection_changed is called twice (once for each click) where as, if the game is already selected then the first click trigger on_selection_changed and the second one triggers on_item_activated

from lutris.

This is indeed a problem with GTK, if we want to workaround this issue, we'd have to basically re-implement double-clicking: Keep track of currently selected game and what time it was selected, on selection changed, check if the current selected game is the same as previously selected game and current_time - last_selection_time < n milliseconds, if so we trigger the on_item_activated signal.

from lutris.

Yes and reimplement activation with Enter and Space or keep on_activation and add double-click detection on top.

Meanwhile, I'll report the bug to GTK.

from lutris.

It was already reported since 2007, yay ! There is a patch though, maybe we can use it... somehow ?

from lutris.

You mean by shipping a patched version of GTK? I don't think that's even possible! No, the best we can do is wait for the patch to be merged and released downstream. Meanwhile we can go with the double-click reimplementation option, even if it feels a bit hackish.

from lutris.

Not shipping GTK, no, I just had the quick unaware thought that maybe it was possible to override the guilty function.

from lutris.

If it were written in Python, you could monkey patch that bit. Actually, it may be possible to monkey patch even if it was written in C (but it would need a python re-implementation of this function and possibly everything around it).
My advice is: don't open that door, do not ever go there, it's not worth it.

from lutris.

My advice is: don't open that door, do not ever go there, it's not worth it.

Stop tempting me ! :P

from lutris.