Giter VIP home page Giter VIP logo

Comments (1)

lvandeve avatar lvandeve commented on July 23, 2024

You're correct, 1-bit RGB does not exist in PNG and is not supported by lodepng either since it only supports the valid PNG color type / bit depth combinations.

In the unit test, the 1 there was a typo, it actually had to be 8, and the test passed by coincidence instead (since it was treating it as 16 bit in the else case and the bit pattern must have matched something valid by coincidence)

Extra error handling in the lodepng_convert and lodepng_get_raw_size functions would be redundant, the error checking for valid color type / bit depth combination already happens elsewhere in the main decoding and encoding flow

Thanks for reporting! I fixed the test to use 8, and 16, instead of the wrong 1 bits.

from lodepng.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.