Giter VIP home page Giter VIP logo

Comments (3)

stinos avatar stinos commented on July 23, 2024 1

Well, unless this isn't intentional, I think this should be rather be considered a doocumentation issue and/or an issue with custom code. I mean, lodepng uses C-style allocation. So if somebody implements custom allocation, he/she must follow that (pretty much canonical) allocation scheme. But you didn't figure out or forgot this means deallocation handles NULL. So IMO the fix is to document that explicitly, not add extra code which is going to be duplicate anyway in 99% of cases out there.

from lodepng.

stinos avatar stinos commented on July 23, 2024

It's NULL not Null or null, and the both C anc C++ standards allow passing NULL to free in which case it does nothing, so I don't think this is an issue?

from lodepng.

kyx0r avatar kyx0r commented on July 23, 2024

Yes, whatever you call it, NULL or nullptr or 0 well anything that describes EAX = 00000000.

As i said its not an issue as it does not crash, however when I replaced it with my custom memory zone allocator I had unexpected a crashes because of it. So that is the reason i reported this. To fix this so that no one else like me runs into this, just put a null check with return in that function, should be good.

from lodepng.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.