Comments (4)
Hi
It's true that using 'sizeof(vgid) - 1' or ID_LEN would be sufficient here,
but I can't imagine how it can cause any crashing of your app ???
Still the buffer is sized as ID_LEN+1 and '\0' is written after the call strncpy().
Can you rather share you 'coredump' trace or at least -vvvv log
before your execution crashes - as it looks like reason might be somewhere else.
from lvm2.
The write side is fine as you say, its the read from vg->id.uuid that whilst is normally fine, it reads an extra byte which is later overwritten. In the specific case of running within the android recovery context (which enforces the use of FORTIFY) does a test on both the read and write side of strncpy and so causes the crash.
from lvm2.
Ahh ok - so it's purely crashing your enforced fortified build - not a normal build - since the access is normally embedded into a volume_group structure so it should not cause any troubles.
I'll push minor change later on.
from lvm2.
Changed upstream with this commit:
https://listman.redhat.com/archives/lvm-devel/2021-August/msg00016.html
from lvm2.
Related Issues (20)
- Resize an logical volume with ntfs on it errors out since 2.03.22 HOT 3
- Error with `lvresize`: `/usr/libexec/lvresize_fs_helper: execvp failed: No such file or directory` HOT 2
- striped lv HOT 2
- lvresize (2.03.22) consistently ignores correct new size and errors out. 2.03.21 works. HOT 1
- Not working RAID thin pool HOT 5
- successful commands output invalid json (trailing comma) for default command_log_selection with --reportformat json HOT 2
- Global lock failed: held by other host HOT 6
- lvcreate is demanding 4 PE/ 16 MiB extra HOT 1
- How to accurately determine actual disk usage in the presence of Logical Volumes spanning multiple physical disks? HOT 4
- 'vgchange -ay' freezes after reboot if we have move_pv HOT 4
- Recommendation to prune archive is printed to stdout, breaking JSON output HOT 1
- lib/cache_segtype/cache.c scans for the symbol smq_exit, but this symbol is not present if smq is compiled into the kernel HOT 3
- ./configure fails with checking for pthread_mutex_lock in -lpthread... no HOT 7
- Allow bypassing lv_cache_wait_for_clean() when spliting/uncaching with dirty blocks HOT 4
- Using lv devices while initial syncing HOT 1
- lvconvert --repair -yf doesn't refresh logical volume
- lvdisplay does not respect --reportformat HOT 1
- Space on LVM partition is not freed up after deleting files HOT 2
- LVM Snapshot got mounted instead of source/Origin's logical volume HOT 1
- Internal error: Referenced LV pvmove0 not listed HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lvm2.