Giter VIP home page Giter VIP logo

Comments (11)

lwthiker avatar lwthiker commented on May 21, 2024 1

I will prioritize it, I might have some free time next week. Sorry for the delay, busy times...

By the way, I understand the need for reusing the curl handle when connecting to the same host, but what is the purpose if you are connecting to a different one? A new connection is initiated, so why not use a new handle?

from curl-impersonate.

lwthiker avatar lwthiker commented on May 21, 2024 1

@momala454 I think I fixed the issue in #62 . I tested the fix using C code, would you mind testing it with your PHP code as well? Once you give me the green light I would merge it to the main branch.

The issue was quite tricky - you found a real edge case here. Luckily the fix was simple.

from curl-impersonate.

momala454 avatar momala454 commented on May 21, 2024

even if I set "Host: hello.com" on the second request, it still send "abc.com" as host when i'm using CURL_IMPERSONATE

from curl-impersonate.

momala454 avatar momala454 commented on May 21, 2024

hello, did you saw this issue ?

from curl-impersonate.

lwthiker avatar lwthiker commented on May 21, 2024

Hi, yes I saw it. Thanks for reporting. My time was quite limited the past week so I didn't manage to inspect this yet.

from curl-impersonate.

momala454 avatar momala454 commented on May 21, 2024

Ok thanks for your hard work

from curl-impersonate.

momala454 avatar momala454 commented on May 21, 2024

hello, could you please look at it, this issue is preventing me to use it. The others issue I mentioned are less important
thank you

from curl-impersonate.

momala454 avatar momala454 commented on May 21, 2024

I have a generic http query to do request and sometimes it will be on different host but sometime the same. Thank you

from curl-impersonate.

foremtehan avatar foremtehan commented on May 21, 2024

@momala454 not related to this issue, But can you tell how are you able to use chrome98 as curl handler in PHP ? I dont this using putenv('CURL_IMPERSONATE=chrome98'); is enough right ?

from curl-impersonate.

momala454 avatar momala454 commented on May 21, 2024

@foremtehan yes it's enough as soon as you use the libcurl from this library instead of the default one

from curl-impersonate.

momala454 avatar momala454 commented on May 21, 2024

@momala454 I think I fixed the issue in #62 . I tested the fix using C code, would you mind testing it with your PHP code as well? Once you give me the green light I would merge it to the main branch.

The issue was quite tricky - you found a real edge case here. Luckily the fix was simple.

thanks for the fix.
I've tested and it worked fine. Take note that I tested with both #62 and #44 at the same time

from curl-impersonate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.