Move the daemon commands under `incus admin` about incus HOT 13 CLOSED

For that one, I think I'd recommend:

• Send an initial PR moving incusd init to incus admin init
• Then do incusd cluster to incus admin cluster
• Then remove import from incusd and move recover to incus admin recover
• Finally move activateifneeded, shutdown and waitready

That should leave us with nothing other than the boilerplate help and version commands as well as the hidden internal subcommands (mostly forkXYZ).

from incus.

Hmm, I didn't think of trying to undo the incus config for both instance and server settings but that's something that may be worth thinking about.

My current plan was to make incus admin restricted to local use only, so no support for remotes or anything at that level, effectively matching what we had with the lxd XYZ commands as those may rely on internal unix-only APIs.

Maybe we should have a separate incus server sub-command with the usual set of set/unset/show/edit/info.
Essentially moving the server config logic over to that and keeping the top-level commands focused on instances.

from incus.

This really would make things a lot nicer. Nee-lxd init was always a weird command to deal with. Is there a nice way to move the daemon configuration stuff from inc config to incus admin as well? I always felt it was strange that daemon and workload configuration was done through the same subcommand. Or would the plan just be to move the daemon subcommands?

from incus.

Sounds good!

from incus.

@stgraber I would like to work on this. Would it be possible to assign this to me?

from incus.

Thanks @stgraber. Those recommendations help a lot.

from incus.

@sharathsivakumar how's that going?

from incus.

@stgraber Sorry was sick for the last few weeks. I am back to work this week. Looking to get the first PR out before the end of this week. Hope that's fine.

from incus.

• incusd init to incus admin init WIP: #79
• incusd cluster to incus admin cluster (Will be skipped)
• incusd recover to incus admin recover#107
• incusd sql to incus admin sql done in #97
• incusd shutdown to incus admin shutdown #99
• incusd waitready to incus admin waitready #100

from incus.

Hey @sharathsivakumar, this is starting to become a bit more of a blocker than it once was, so I'm planning on spending some time tomorrow in my weekly live stream going through a bunch of those so we can close this issue ahead of Incus 0.1.

Let me know if you have some existing partial code, or better, open a draft PR with anything you have and I'll take it from there!

from incus.

@stgraber I have partial code for recover and sql. I will create a few PRs for all those I worked and you can take it from there.

from incus.

@sharathsivakumar thanks!

from incus.

Thanks to @sharathsivakumar we now have everything we can move, moved to the incus admin space.

I'll now take this over and send a small follow-up to:

• Tidy up the help of incusd
• Introduce an incus admin cluster sub-command which attempts to redirect to incusd admin cluster or tells the user that cluster recovery must be done through incusd
• Do a quick look over the new admin XYZ commands to make sure they're in line with other client commands, thinking specifically about getting all their strings included in the translation template.

And that will be a wrap on that one.

from incus.