With VTE 0.54, hitting X button of one tab closes all tabs about lxterminal HOT 5 CLOSED

Anything wrong with a4eaef4? That works fine for me.

from lxterminal.

Inside terminal_close_button_event(), replacing terminal_child_exited_event(vte, 0, term); by gtk_widget_destroy(term->vte); seems to work for me at first glimpse. I'm not sure if this is the proper solution.

(Perhaps should be conditional to vte-0.54, leaving the old code path for older vte versions, I haven't tested that.)

Note though that terminal_close_button_event()'s signature is confusingly broken. The first argument it receives and forwards to terminal_child_exited_event() is a GtkButton (the close button) and not a VteTerminal. Looks like a more thorough check of the code around these bits is desirable.

from lxterminal.

Probably a fix along the lines of https://bugs.launchpad.net/sakura/+bug/1790317 would be better, that is, to explicitly disconnect the child-exited signal before removing vte from the widget hierarchy.

(I'd let you guys play with it, I'm not planning to further work on this issue.)

from lxterminal.

Note though that terminal_close_button_event()'s signature is confusingly broken. The first argument it receives and forwards to terminal_child_exited_event() is a GtkButton (the close button) and not a VteTerminal. Looks like a more thorough check of the code around these bits is desirable.

This is addressed in a4eaef4 as well.

However, for this issue please test and reopen if disconnecting the signal on child-exited doesn't help.

from lxterminal.

My mistake. I was running on wrong binary to test it and found out the bug "persists".

from lxterminal.