How to remove newline between import groups? about eslint-plugin-simple-import-sort HOT 12 CLOSED

@keemor Hi!

You need to put everything in the same array, like this:

{
  "plugins": ["simple-import-sort"],
  "extends": "react-app",
  "rules": {
    "simple-import-sort/sort": [
      "warn",
      {
        "groups": [
          [
            // Packages. `react` related packages come first.
            "^react",
            "^@?\\w",
            // Internal packages.
            "^(components|modules|utils)(/.*|$)",
            // Side effect imports.
            "^\\u0000",
            // Parent imports. Put `..` last.
            "^\\.\\.(?!/?$)", "^\\.\\./?$",
            // Other relative imports. Put same-folder imports and `.` last.
            "^\\./(?=.*/)(?!/?$)", "^\\.(?!/?$)", "^\\./?$",
            // Style imports.
            "^.+\\.s?css$"
          ]
        ]
      }
    ],
    "import/first": "warn",
    "import/newline-after-import": "warn",
    "import/no-duplicates": "warn",
  }
}

(I didn’t test that before posting, so forgive me if I made a mistake 🙏)

from eslint-plugin-simple-import-sort.

This is now possible in v5.0.0 using custom grouping.

For example:

{
  "rules": {
    "simple-import-sort/imports": [
      "error",
      {
        "groups": [["^\\u0000", "^@?\\w", "^[^.]", "^\\."]]
      }
    ]
  }
}

(Edited for newer version based on #25 (comment))

from eslint-plugin-simple-import-sort.

Thanks for the reply. OK, I undetstand plugin design.

I want to remove line breaks between all import statements. This is my personal opinion because I usually don't put a newline between import statements. So, not important. But I would be happy if option was provided like https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/order.md#newlines-between-ignorealwaysalways-and-inside-groupsnever.

Thank you for your polite response!

from eslint-plugin-simple-import-sort.

Hi,

Having this option would be nice for people using typescript.

Migrating from tslint to eslint, this plugin is the only one that can behave like tslint ordered-imports rule... except that tslint default rule configuration disables new line between groups.

Would be great to be able to have the same configuration as tslint.

from eslint-plugin-simple-import-sort.

This is now possible in v5.0.0 using custom grouping.

For example:

{
  "rules": {
    "simple-import-sort/sort": [
      "error",
      {
        "groups": [["^\\u0000", "^@?\\w", "^[^.]", "^\\."]]
      }
    ]
  }
}

Just to expand on this.

For future visitors, "simple-import-sort/sort" will give error (above v6.0.0)

• Definition for rule 'simple-import-sort/sort' was not found.eslint(simple-import-sort/sort)

Replace the "simple-import-sort/sort" with "simple-import-sort/imports", like this

"simple-import-sort/imports": [
      "error",
      {
        "groups": [["^\\u0000", "^@?\\w", "^[^.]", "^\\."]]
      }
]

It's also mentioned in the readme here.

Thanks.

from eslint-plugin-simple-import-sort.

I have a thing coming up that will allow customizing this.

from eslint-plugin-simple-import-sort.

This feature of grouping is great but will be nice to make an example on the documentation because it was clear only after searching newline

from eslint-plugin-simple-import-sort.

Hi!

This plugin has no options by design. There is currently no way of removing that newline.

Would you like to tell me more about this unwanted line break? Do you want no linebreaks at all between imports? Or just between those two groups that you showed? Why is it important? Etc.

from eslint-plugin-simple-import-sort.

@hrougier https://palantir.github.io/tslint/rules/ordered-imports/

Groups of imports are delineated by blank lines.

But you say the default is having no blank lines between groups?

from eslint-plugin-simple-import-sort.

But you say the default is having no blank lines between groups?

That's it, blank lines between groups is an option which is not enabled by default:

"rules": {
    "ordered-imports": true // rule activated, no blank lines
  }

"rules": {
    "ordered-imports": [true, { "grouped-imports": true }] // to enable blank lines
  }

from eslint-plugin-simple-import-sort.

Ok. I guess their docs is a little misleading, then. I have an idea for this that I want to play with this week.

from eslint-plugin-simple-import-sort.

Hi @santomegonzalo, @lydell :)
How to remove empty lines between groups? My .eslint looks like this:

{
  "plugins": ["simple-import-sort"],
  "extends": "react-app",
  "rules": {
    "simple-import-sort/sort": [
      "warn",
      {
        "groups": [
          // Packages. `react` related packages come first.
          ["^react", "^@?\\w"],
          // Internal packages.
          ["^(components|modules|utils)(/.*|$)"],
          // Side effect imports.
          ["^\\u0000"],
          // Parent imports. Put `..` last.
          ["^\\.\\.(?!/?$)", "^\\.\\./?$"],
          // Other relative imports. Put same-folder imports and `.` last.
          ["^\\./(?=.*/)(?!/?$)", "^\\.(?!/?$)", "^\\./?$"],
          // Style imports.
          ["^.+\\.s?css$"]
        ]
      }
    ],
    "import/first": "warn",
    "import/newline-after-import": "warn",
    "import/no-duplicates": "warn",
  }
}

from eslint-plugin-simple-import-sort.