Giter VIP home page Giter VIP logo

Comments (4)

lykmapipo avatar lykmapipo commented on May 29, 2024

@rishabhmhjn

May you please add a spec/scenario that fail the current implementation. As far as sails hook implementation is concern and regardless of the number request all request will be processed to obtain their locale.

Is it bad idea is attaching locale to a request object?. If so am open for the correct implementation.

from sails-hook-validation.

rishabhmhjn avatar rishabhmhjn commented on May 29, 2024

Got that.
Please give me sometime to create an appropriate test for it.
Will update you over here

from sails-hook-validation.

lykmapipo avatar lykmapipo commented on May 29, 2024

@rishabhmhjn

Thanks.

from sails-hook-validation.

armellarcier avatar armellarcier commented on May 29, 2024

@rishabhmhjn I don't see how you proposition fixes anything. You set a property on a global. The before hook can be called numerous times before you access the requestLocale in the validateCustom function anyway.

I can't think of a way of fixing the problem without a reference to the request in the validateCustom function.

from sails-hook-validation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.