Comments (4)
May you please add a spec/scenario that fail the current implementation. As far as sails hook implementation is concern and regardless of the number request all request will be processed to obtain their locale.
Is it bad idea is attaching locale to a request object?. If so am open for the correct implementation.
from sails-hook-validation.
Got that.
Please give me sometime to create an appropriate test for it.
Will update you over here
from sails-hook-validation.
Thanks.
from sails-hook-validation.
@rishabhmhjn I don't see how you proposition fixes anything. You set a property on a global. The before
hook can be called numerous times before you access the requestLocale
in the validateCustom
function anyway.
I can't think of a way of fixing the problem without a reference to the request in the validateCustom
function.
from sails-hook-validation.
Related Issues (20)
- Throw Custom Error HOT 1
- Custom validation message does not work HOT 1
- TypeError: request.getLocale is not a function HOT 3
- Does not work with blueprints HOT 6
- Installation error HOT 4
- Does not work with sails-hook-autoreload HOT 2
- bug in sails 0.12 HOT 6
- No Errors on latest sails.js HOT 1
- Use without i18n shows a locale warning HOT 1
- Use Field values in i18n translations HOT 1
- Model.validate optional argument
- Enum error HOT 1
- Unique not working with primary key HOT 3
- this module does not appear to work HOT 2
- Not returning custom errors with Sails 0.12.9 HOT 4
- Errors on Sails 1.0 installations HOT 1
- Not adding custom messages in Sails v1.0.0-36 HOT 4
- throw errors in sails v1.0.0-37 HOT 6
- Not working with sails blueprint
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sails-hook-validation.