Make markymark safe to use in extensions about marky-mark HOT 6 CLOSED

Just release the new version!

from marky-mark.

Thanks for your input.

Is it possible to be any more specific? Which parts of markymark are not safe for extensions/frameworks and what solution are you proposing?

Regards,

Jim

from marky-mark.

The problem is the use of UIApplication.shared.openURL(url) in AttributedInteractiveLabel. UIApplication is not extension safe.
The proposed solution is to "hide" the API usage by using NSClassFromString(@"UIApplication") instead of UIApplication directly. This approach apparently also worked for SDWebImage.

from marky-mark.

An alternate, less hacky, solution could be delegation, where AttributedInteractiveLabel would have a delegate that gets informed about opening the url, but that might be a breaking change in the API. Also the AttributedInteractiveLabel will not be a drop-in solution any more if link handling is required.

from marky-mark.

Thanks for your input @mhoeller-clue, i looked into your pull-request and made #74 inspired by your approach.

This pull request will allow markymark to compile in extension by using NSSelectorFromString("sharedApplication") instead using UIApplication.shared directly.

Also, this pull request will allow customization of the open url behavior by providing an implementation of URLOpener

My collegues will review the pull request and i will let you know as soon as i release a new version. Also, let me know what you think of this approach!

from marky-mark.

Looks perfect! It has much deeper integration throughout the system and extends the example project too 👍
Thanks for putting the work into this library! Looking forward to the new version.

from marky-mark.