Errors from subtasks are re-thrown even when caught about ember-concurrency HOT 10 CLOSED

Ah I see what the problem is... right now e-c only considers errors "caught" if you call .then / .catch on the task instance, but catching in the catch block of a parent task presently isn't being handled.

Should have a fix for this soon.

from ember-concurrency.

At first I didn't think our scenario was the same as this one but then (well, just now) I realized that the double-thrown-error thing only occurred when we saved stuff in modals, and yeah, we pass a task to our modals and our modals has their own task that performs the provided task. So our issue is indeed exactly the same parent/sub-task thing described above.

from ember-concurrency.

...well, except we don't catch anything in the parent task so our error is thrown twice.

from ember-concurrency.

Sorry for rubber ducking here but I've successfully created a reproduction at https://canary.ember-twiddle.com/3f06ac7ae7accc397a171b494b9b0f64?openFiles=application.controller.js

(for some reason I can't click but have to tab to the perform button)

from ember-concurrency.

Fixed and release in 0.6.2

from ember-concurrency.

It looks like this is solved for direct descendants, but if the handler is more than one task "layer" away, I'm still seeing window.onerror get triggered in this twiddle with 0.6.2.

from ember-concurrency.

@dfreeman yeah, I see it too, and @wecc reported in the Slack channel that if you don't catch an error, you get double error reports. I have an idea for how to fix, will tackle shortly.

from ember-concurrency.

@wecc @dfreeman could you please try out the double-error-fix branch to see if this problem's finally fixed?

from ember-concurrency.

@machty That looks like it did the trick! (...and uncovered a small bug in our global error handler, too)

from ember-concurrency.

Sorry for the late response – confirming that 0.6.3 solves the issue in our app! ❤️

from ember-concurrency.