Giter VIP home page Giter VIP logo

Comments (10)

gellermark avatar gellermark commented on June 2, 2024 1

@nofishdesign I'm not trying to make exact representation of the flags, I want to make them recognisable and sharp for most screens. It's a balance act when deciding what to simplify and what to keep.

If you take a closer look at many of the other flags they are highly simplified to work in 15*21 pixels. If you choose to create your own version of any flag in addition to using FlagKit for the rest you can of course do so 👍

from flagkit.

denissamoilov avatar denissamoilov commented on June 2, 2024

The Chinese flag is wrong, please don't use it!

Would you be more specific, what is wrong?

from flagkit.

nofishdesign avatar nofishdesign commented on June 2, 2024

This is the Chinese flag. Note that the four small stars are five-pointed stars; your picture is four-pointed
image

from flagkit.

gellermark avatar gellermark commented on June 2, 2024

The icons are meant to be used in super small scales. The reasoning behind the four-point stars is that they get less blurry in comparison to the five-pointed stars. They are not meant to be seen in the scale you show.

image

With more detailed flags it would look even worse :)

from flagkit.

denissamoilov avatar denissamoilov commented on June 2, 2024

Totally agree with @gellermark , many flags have 4-pointed stars, because on smaller resolution it would't look like a circle/dot. That's why this library is much better than many others, because of low detailing. For example check Brazil flag, it doesn't have stars at all: https://github.com/madebybowtie/FlagKit/blob/master/Assets/PNG/BR%403x.png

from flagkit.

nofishdesign avatar nofishdesign commented on June 2, 2024

This is not about the display effect, the national flag is a symbol of a country!I hope you can fix it

from flagkit.

zenorocha avatar zenorocha commented on June 2, 2024

Hello there, I'm using FlagKit in one of my projects and I heard a similar complaint about this. I understand the thought process about keeping it that way, but still, I wanted to bring visibility that more people might be facing this problem.

from flagkit.

nofishdesign avatar nofishdesign commented on June 2, 2024

from flagkit.

denissamoilov avatar denissamoilov commented on June 2, 2024

@nofishdesign then this kit doesn't suit you :)
Screenshot 2021-04-19 at 10 07 08 how many points is here?

from flagkit.

nofishdesign avatar nofishdesign commented on June 2, 2024

from flagkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.