add postcss-aspect-ratio about rucksack HOT 10 OPEN

sweet. I'll PR this

from rucksack.

Would love to see this functionality added, its a nice shortcut for a common css code pattern 👬

from rucksack.

@seaneking would you accept a PR with this?

from rucksack.

whoops sorry missed this. Not sure if aspect ratio us a good fit for rucksack or not, it's quite heavy handed it what it does. As a developer looking through code with that declaration in it, I wouldn't expect the children of the element to be absolutely positioned etc etc.

More than happy to get feedback from the community on this one though, if there's demand for it then would definitely consider it.

from rucksack.

It's a very standard (and crucial imho) technique, but obviously it's your call. :)

from rucksack.

The padding hack is, but all the other assumptions postcss-aspect ratio make aren't (abspos children etc). That said haven't looked at it for a while.

from rucksack.

There's no other way to do content inside it without it.

from rucksack.

+1 for aspect ratios!

I find myself needing to do that more often that I would have thought.

from rucksack.

Okay, sounds like I'm the minority on this one. Would accept a PR.

While we're all here - what do we think of #47?

FWIW postcss-alias is pretty buggy, and the bugs are pretty fundamental (regexing aliases out of both property names and values).

from rucksack.

Excited that this will be added - another vote for it!

from rucksack.