Giter VIP home page Giter VIP logo

Comments (9)

tommydangerous avatar tommydangerous commented on May 22, 2024

πŸ‘€ looking

from mage-ai.

tommydangerous avatar tommydangerous commented on May 22, 2024

So sorry for the inconvenience and issues. Our team is looking at this and will get it resolved ASAP.

We’ll keep you updated on our progress.

from mage-ai.

Travior avatar Travior commented on May 22, 2024

As far as I can tell this appears to be a bug (?) in jinjas template splitting function which seems to be incompatible with windows "\" directory seperator.
The bug doesn't appear with transformers and sensors since their functions don't use os.path.join(template_folder, 'default.jinja')
but rather generate the path with forward slashes, which don't break jinja (e.g., template_path = 'transformers/default.jinja')
I could create an issue in the jinja repo to see if this behavior is intentional, but could also create a PR that fixes the problem regardless of whether this interaction is wanted from jinja's side

from mage-ai.

tommydangerous avatar tommydangerous commented on May 22, 2024

Wow, thank you so much for figuring out the root cause.

"I could create an issue in the jinja repo to see if this behavior is intentional, but could also create a PR that fixes the problem regardless of whether this interaction is wanted from jinja's side"

^ +1 to that. This would be amazing, thank you so much! πŸ™

from mage-ai.

Travior avatar Travior commented on May 22, 2024

So I've done some digging in the jinja issues and found this thread pallets/jinja#1378 (comment)

To me, it seems like they intend this behavior, meaning that paths that use the split_template_path function should probably be sanitized (maybe just with a simple path.replace("\\", "/")?)

from mage-ai.

lucafaggianelli avatar lucafaggianelli commented on May 22, 2024

I have the same issue on windows, did you find a solution? This is quite a problem as you can't create python files from the UI

from mage-ai.

tommydangerous avatar tommydangerous commented on May 22, 2024

@lucafaggianelli we’re working on this fix, so sorry for the inconvenience.

from mage-ai.

wangxiaoyou1993 avatar wangxiaoyou1993 commented on May 22, 2024

@Travior @lucafaggianelli This bug has been fixed in version 0.7.19. Let us know if you still have template loading issue in windows.

from mage-ai.

wangxiaoyou1993 avatar wangxiaoyou1993 commented on May 22, 2024

PR: #1476

from mage-ai.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.