Comments (8)
erikhansen
commented on August 16, 2024
2
I ran into the same issue with PHPCS 3.0.0. I downgraded to PHPCS 2.9.0 and it worked just fine for me. I just submitted a PR to update the README with this information.
Screenshot demonstrating that this only works with 2.9.0:
from coding-standard.
andreasemer
commented on August 16, 2024
2
Thx @Zifius this works for me with version 3.0 👍
from coding-standard.
Zifius
commented on August 16, 2024
1
Cool, thanks for checking @erikhansen, I've sent email to @zlik so we should get it into master soon if the PR passes review therefore I propose closing #51
P.S. You might want to check my small project https://github.com/Zifius/Magizendo which is based on this one
from coding-standard.
Zifius
commented on August 16, 2024
1
Hi @erickpatrick, I emailed @zlik on the same day I did the PR so he either busy or on vacation. Anyway go on and review my changes and their own compliance with the coding standards (which I was fixing for PSR-2). I'll try to get merge rights for this project since I'm ECG member as well. Thanks for your help in advance
from coding-standard.
erfanimani
commented on August 16, 2024
Thanks, yeah, downgrading to 2.9 worked for me too.
…On 19 May 2017 01:24, "Erik Hansen" ***@***.***> wrote:
I ran into the same issue with PHPCS 3.0.0. I downgraded to PHPCS 2.9.0
and it worked just fine for me. I just submitted a PR
<#51> to update the
README with this information.
Screenshot demonstrating that this only works with 2.9.0:
[image: 12-23-47 new message-pzco5]
<https://cloud.githubusercontent.com/assets/129031/26215165/e9e67fe4-3bc4-11e7-8a93-fb76744ba359.png>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#48 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA4ypnCJTLanC3JF9YlC8thbeF8lvm8zks5r7H7TgaJpZM4M-l2j>
.
from coding-standard.
Zifius
commented on August 16, 2024
Hi guys, can you check if #52 works well for you?
from coding-standard.
erikhansen
commented on August 16, 2024
@Zifius I pulled in the code from your pull request and it appears to work great with CodeSniffer 3.0. Thanks for working on this! Screenshot demonstrating it working:
from coding-standard.
erickpatrick
commented on August 16, 2024
So, since May 4th the project PHPCodeSniffer released its version 3.0.0. It would be really interesting to see some movement/response regarding the code review.
If needed I can help code reviewing it,.
from coding-standard.
Related Issues (20)
- Error Functions HOT 1
- exception thrown in /usr/share/php/PHP/CodeSniffer.php HOT 2
- something bad in file_exists? HOT 1
- Warning message for non-plugin class HOT 2
- Can't use EcgM2 with composer HOT 8
- Referenced sniff "Generic.PHP.Syntax" does not exist
- Can you please do more frequest releases? HOT 3
- Coding Standard Clarification HOT 1
- "Plugin beforeSave function should have at least two" HOT 2
- Magento 1.x - Performance Loop Sniff HOT 1
- False positives with NamespaceSniff HOT 2
- Shall we folllow the official coding standards? HOT 1
- Why is parse_url forbidden? HOT 5
- Can someone explain to me what is bad about a good use of call_user_func(_array) HOT 2
- tempnam alternative to create temporary files - M1 HOT 1
- php code sniffer not working in windows 8.1 xampp , php version 5.6 HOT 1
- Empty diff HOT 2
- Uncaught TypeError: vsprintf(): Argument #2 ($values) must be of type array, string given in vendor/squizlabs/php_codesniffer/src/Files/File.php:1056 HOT 3
- Internal error fo do...while HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from coding-standard.