Uncaught TypeError: $(...).select2 is not a function about magepack HOT 7 OPEN

@krzksz FYI It doesn't work because select2 lib includes define( multiple times for example:
define(['jquery'], factory);

S2.requirejs = requirejs;S2.require = require;S2.define = define;
S2.define("almond", function(){});

here's the condition from magepack/lib/bundle.js

else if (!moduleContents.match(/define\s*\(\s*['"]/m)) {
    moduleContents = moduleContents.replace(
        /define\s*\(/m,
        `define('${moduleName}', `
    );
}

It will not work because it will catch define("almond"

Not sure how to fix it but maybe you can check if there is no . before define in this expression or just search for only first occurance of define

from magepack.

@orthener I discovered when bundling with Magepack the select2 module doesn't get a unique name so once part of the bundle file you get the anonymous mismatched error.

As a quick fix you can manually add a name to the select2.js which will then allow it to work correctly in the bundle, see below.

(function (factory) { if (typeof define === 'function' && define.amd) { // AMD. Register as an anonymous module. define('**your_unque_name**', ['jquery'], factory); } else if (typeof module === 'object' && module.exports) {

from magepack.

# magepack.config.js. Autogenerated
module.exports = [
    {
        url: [],
        name: 'product',
        modules: {
            ...
            'js/vendor/select2/select2.full.min': 'js/vendor/select2/select2.full.min',
            ...
        }
    },
]

# requirejs-config.js
var config = {
    map: {
        '*': {
        select2: 'js/vendor/select2/select2.full.min' // replace default select with full
    }
};

In magepack.config.js tried:

'select2': 'js/vendor/select2/select2.full.min',

Same result

from magepack.

Have you applied the "Refactor JavaScript mixins module" patch ?

from magepack.

I'm also seeing the same error with select2. I have the mixins patch applied.

This doesn't occur when bundling with Baler or DevTools/r.js.

from magepack.

Have you applied the "Refactor JavaScript mixins module" patch ?

Yes.

from magepack.

Stumbled upon this as well. Naming the define in the select2 code breaks the developer mode, when magepack is not active though, so we just went with removing it from the magepack bundle which is a fine workaround for the moment for us.

from magepack.