Can't find `TextEncoder` in tests after 2.2.2 release about moderndash HOT 8 CLOSED

Sounds good 👍 I might change the function to only create the TextEncoder object when actually needed.
I need to check benchmarks what impact this would have though.
Without tree-shaking (i.e. in tests) TextEncoder gets called without ever getting used.

from moderndash.

Without tree-shaking (i.e. in tests) TextEncoder gets called without ever getting used.

I will just add that tree-shaking is usually done only in production builds (as it's computation heavy), so I assume that moderndash, in dev mode, will break also in e.g. Next.js as it does two separate builds - for the server and for the browser.

from moderndash.

@karol-f Fixed in 991a1d9 v2.2.3

TextEncoder is only created when its needed in hash

You can close this issue if it works for you 👍

from moderndash.

Mhh TextEncoder should be a global and doesn't need an import.
https://developer.mozilla.org/en-US/docs/Web/API/TextEncoder?retiredLocale=de

On the first glance it looks like an issue outside of moderndash. It only appeared now in v2.2.2 because I moved the TextEncoder to the outer scope. Before it was generated in the hash function itself.

@karol-f can you give me a reproducible repo on stackblitz for example?
I will look at it there.

from moderndash.

A google search showed me this, seems to be related: inrupt/solid-client-authn-js#1676

Seems like a jest issue. This probably fixes it for you: https://stackoverflow.com/a/68468204

from moderndash.

Thanks for the hints, I will try to resolve it myself with e.g. @inrupt/jest-jsdom-polyfills package.

from moderndash.

Importing @inrupt/jest-jsdom-polyfills in setupFilesAfterEnv: ['<rootDir>/jest-setup.ts'] file worked for me.

I just wonder if we really need TextEncoder in Node environment (e.g. in tests or Next.js on server-side).
This did a trick for me, works in both environments (when only importing merge from moderndash):

var textEncoder = typeof TextEncoder === 'function' ? new TextEncoder() : undefined;

Obviously, this second way will fail if you actually will use some method with TextEncoder usage, but at least it won't break every time in Node, without pollyfill.

from moderndash.

I can confirm that it's working now :) Thank you!

from moderndash.