Giter VIP home page Giter VIP logo

Comments (6)

shiffman avatar shiffman commented on August 14, 2024

Something must be going on in my markup as this file builds no problem.

https://github.com/shiffman/The-Nature-of-Code/blob/id_bug/chapters/tip_test.html

from magicbook.

runemadsen avatar runemadsen commented on August 14, 2024

Hmm, interesting. Currently, I'm generating those ID's based on the tip's position in the DOM. So maybe they all have the same position in the files? Can you post the files array I need to have to make this happen, and I'll take a look.

from magicbook.

shiffman avatar shiffman commented on August 14, 2024

As far as I can tell, any 6 chapters. For example:

https://github.com/shiffman/The-Nature-of-Code/blob/master/magicbook.json

   "files":[
      "chapters/01_vectors.html",
      "chapters/02_forces.html",
      "chapters/03_oscillation.html",
      "chapters/04_particles.html",
      "chapters/05_physicslib.html",
      "chapters/06_steering.html"
   ],

from magicbook.

runemadsen avatar runemadsen commented on August 14, 2024

Great. Let me take a look and try to fix this.

from magicbook.

runemadsen avatar runemadsen commented on August 14, 2024

I've just confirmed that this is a bug in the ID rendering. Fixing now.

from magicbook.

runemadsen avatar runemadsen commented on August 14, 2024

Ok, this is fixed in 0.1.5. I added a test so we're sure this doesn't happen again:
https://github.com/magicbookproject/magicbook/blob/master/spec/plugins/ids_spec.js#L22-L38

from magicbook.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.