new nodejs parser: llhttp about httptools HOT 9 CLOSED

We don't really have the bandwidth to make the switch, but if anyone wants to pick this up, patches are welcome!

from httptools.

@victoraugustolls I'd be happy to help!

You basically need to do what Node.js does at this moment if you'd like to raise an error from the on_body/etc callbacks:

      llhttp_set_error_reason(&parser_, "HPE_JS_EXCEPTION:JS Exception");
      return HPE_USER;

from httptools.

Thanks to @victoraugustolls and everyone, this is done in #56. I'll get a release out soon.

from httptools.

Hey @elprans ! Do you have an opinion about moving to llhttp? As http-parser is no longer maintained :(

from httptools.

Hi @elprans ! I'm trying to take this one here: https://github.com/victoraugustolls/httptools

I'm having some trouble with the tests due to some missing exceptions between http-parser and llhttp. Could you help me? Or point me someone to help?

The problem is that there are no callback errors for on_body, on_header, on_url and on_status. Other point is that I had to change how the upgrade works, but don't know if this is correct.

Maybe @indutny can help also? (sorry if tagging you here is wrong)

from httptools.

Perfect! Thanks @indutny ! Will give it a go over the weekend!

from httptools.

Is there any progress?

from httptools.

Hey @abersheeran ! There is an open PR for it: #56

from httptools.

We've hit a delay with EdgeDB, but integrating httptools deeper in it is on my immediate todo. And so I'll be closely looking at that and will also likely release uvloop for 3.9. Sorry for the delay.

from httptools.