Giter VIP home page Giter VIP logo

Comments (8)

bhollis avatar bhollis commented on September 18, 2024 3

That's unfortunate. It was really quick to be able to do that. I also hadn't ever learned that I could select the options by typing - and the letter. It's good to know that I can, but my muscle memory is still to just tap the arrow keys once or twice to find the option I'm looking for.

from transient.

return42 avatar return42 commented on September 18, 2024 1

Sorry for being ignorant, but I don't see the benefit of modal (transient) dialogs (for me). I have been using the emacs for 30 years and have never (consciously) perceived a modal dialogue. I like to be the master of any buffer, navigating with up/down arrow keys and using incremental search. Now I feel like in a jail, that is what I know from other IDE, not from emacs.

Is there a way to disable such modal dialogs?

from transient.

kyleam avatar kyleam commented on September 18, 2024

This was touched on in #17, where Jonas said, "Isearch and selecting a suffix using the arrow keys or the mouse is still not possible again. Not sure if I want to bring that back."

from transient.

return42 avatar return42 commented on September 18, 2024

Another point with transient, long know keystrokes do no longer work (e.g C-c C-cis now C-x C-s) .. phew!

from transient.

tarsius avatar tarsius commented on September 18, 2024

I was actually just about to start working on bringing back arrow navigation...

have never (consciously) perceived a modal dialogue

Please read this first: #17 (comment).

In summary. Transient popups are like incomplete key sequences. You can only invoke commands that are available given the current incomplete key sequence or abort. One could call that a modal interface. Transient differs from regular prefix keys in that it shows you the available suffixes in a buffer. That causes it to be perceived as more modal, but really it is exactly the same as for regular incomplete key sequences except for the visual feedback.

Additionally note the explanations about the popup buffer not being the current-buffer and why that is useful.

Is there a way to disable such modal dialogs?

You can set transient-show-popup to nil. This prevents the popup from being shown. Instead you get something like this in the echo area:

c- [magit-commit] -A|-C|-R|-a|-e|-n|-s|-v|A|F|S|a|c|e|f|n|s|w|x

You can also set it to 0 in which case you see only:

c-

I.e. the transient then behaves exactly like a regular prefix command. Well almost, if you press - then the popup is shown. If that were not the case, then you wouldn't be able to know whether then pressing a enables or disables the --all argument.


All that being said I do take these concerns seriously. I just want users to know why I have done things the way I have and that it enables features that would otherwise not be possible.

So I am going to bring back some functionality that was lost due to Transient being more modal but without making it less modal. I still think that whether it should be considered more modal is a matter of perception, but if that's your perception, then I won't deny you that. 😉

from transient.

tarsius avatar tarsius commented on September 18, 2024

Another point with transient, long know keystrokes do no longer work (e.g C-c C-cis now C-x C-s) .. phew!

The rational is explained here: https://magit.vc/manual/transient/FAQ.html#Why-did-some-of-the-key-bindings-change_003f.

from transient.

return42 avatar return42 commented on September 18, 2024

@tarsius thanks for your feedback. I have read the docs you linked but I have a doubt that I have understood all in deep ;) I really will give it a try. ATM it is hard for me to change my keystrokes that flow out of my fingers routinely without me ever thinking about it.

I still think that whether it should be considered more modal is a matter of perception ...

Since I can't change to any other buffer. Anyway, thanks for all your work on magit-popup and transient!

from transient.

tarsius avatar tarsius commented on September 18, 2024

Arrow key navigation, mouse support, and isearch support have been restored. You need to set an option to enable these features. See #42.

from transient.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.