Broken with emacs-24.5 due to pcase-dolist. about with-editor HOT 9 CLOSED

Ah crap, I have started using it again... will fix today. (And add a comment to prevent this from happening in the future.)

from with-editor.

Maybe enabling CI here could help us too?

from with-editor.

Maybe enabling CI here could help us too?

Sure I have just done that on the travis branch.

But that would not help us catch compile warnings. Do you know how to turn those into errors? (I would like if you would still see all warning before compiling is aborted and Emacs exits.)

But even then we would not have caught this. For some reason this does not even give a warning. https://travis-ci.org/magit/with-editor/jobs/280556868

from with-editor.

For some reason

Ah! This is not correct:

pcase-dolist is not available in emacs-24.5.

It's only not autoloaded.

Which means that we should not only require pcase at compile time. (1b7f6ef#commitcomment-24599013)

from with-editor.

But that would not help us catch compile warnings. Do you know how to turn those into errors?

Yes, I have done this for el-get's test scripts, I will put something up tonight.

It's only not autoloaded.
Which means that we should not only require pcase at compile time.

Sorry, I'm getting a bit confused with the not only/only not, could you elaborate please?

from with-editor.

We have to require it at load-time too.

from with-editor.

Hmm, I don't see why; it's a macro so it should only be needed while compiling, no?

from with-editor.

Ah you are right.

from with-editor.

But that would not help us catch compile warnings. Do you know how to turn those into errors?

Yes, I have done this for el-get's test scripts, I will put something up tonight.

In fact, it was even more trivial than I remembered. For el-get I had made something fancier to disable some warnings on different versions, here we just need to set byte-compile-error-on-warning. See #39.

from with-editor.