Comments (3)
tarsius
commented on July 17, 2024
However, that fires too early.
I can confirm that this now (Emacs 25.1 ish) is the case, but I think this wasn't the case earlier. It appears that term-mode-hook is now run earlier than it used to. We don't want to use term-exec-hook to run it before every command; running export EDITOR=... once is enough, but of course the shell process already has to exist.
from with-editor.
sfllaw
commented on July 17, 2024
@tarsius, I think that term-exec-hook only runs after every term-exec.
Which makes sense. If you kill the term buffer's process and then term-exec a new shell, you want the export EDITOR=... to run again.
from with-editor.
tarsius
commented on July 17, 2024
You are right; I misunderstood term-exec-hook's doc-string. Thanks!
from with-editor.
Related Issues (20)
- `export` output on new terminal buffers HOT 2
- No output in eshell on with-editor export HOT 2
- with-editor fails in term-mode. HOT 10
- `git` not found, despite `magit-git-executable` being set. HOT 15
- sleeping editor does not set `with-editor-previous-winconf` HOT 4
- Cannot commit from Magit on Windows 11
- magit-commit editor breakage after updating emacs master HOT 12
- unexpected EOF while looking for matching `'' trying to edit agenix secret with `agenix -e` HOT 1
- Cannot determine a suitable Emacsclient HOT 2
- shell-commands not seeing $EDITOR override HOT 5
- EDITOR setting in vterm breaks remote programs calling EDITOR HOT 2
- When cancelling an edit, why do we send USR2 instead of USR1? HOT 4
- homebrew emacs-plus breaks with-editor--setup HOT 10
- Can't call emacsclient.exe on Windows HOT 7
- [BUG] make-process--with-editor-process-filter: Creating pipe: Too many open files HOT 6
- Emacs Snap installation - unable to commit via magit HOT 3
- Failure after update of Emacs from 28.2 to 29.1 HOT 1
- shell-command-with-editor-mode: path is treated as local for remote files HOT 2
- `magit-status' reports failed to provide feature ‘with-editor’ HOT 39
- Tag latest release HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from with-editor.