Comments (10)
Sure, that would work!
from composerrequirechecker.
Overall understandable request, but really, I'd rather throw an exception that says it is unsupported. I even throw exceptions when I find a custom "vendor-dir"
(on other projects of mine). It breaks so many assumptions that you'd really need to go hunting around the ecosystem in general.
from composerrequirechecker.
Yep, I can see that. I am fine with that. Took me a bit to figure out why it literally didn't find any of the dependencies in a project were that is all custom...
I guess having a "not supported" message would be something :)
Maybe I create just a super custom version for that.
from composerrequirechecker.
Took me a bit to figure out why it literally didn't find any of the dependencies in a project were that is all custom...
Instead of detecting from composer.json
, we may ask the user for a path - probably better? Would allow testing projects with multiple composer installations too.
from composerrequirechecker.
Supporting vendor-dir
should be easy to do. The mentioned code already gets the composer.json
path to the main project and already reads that file to scan for "require"
dependencies.
Adding to read the value of ["config"]["vendor-dir"]
and assuming "vendor"
as default shouldn't be too much hassle. Note that this config value is "root-only", so it basically is just using one fixed or one dynamic directory name.
Haven't looked into install-dir
, but because this is per-package required, I'd rather just emit a notice if possible.
What do you think? Adding support for vendor-dir
?
from composerrequirechecker.
@SvenRtbg send a patch :-)
from composerrequirechecker.
Here we are, I have a patch proposal.
from composerrequirechecker.
While I'm at it: Why does this project allow minimum-stability:dev
for it's dependencies? I get it from the commit history that once the nikic/php-parser version 2 required was unstable, but this never got reverted even though stable versions are available for everything.
from composerrequirechecker.
@SvenRtbg separate patch if you want - I think it's just a leftover :)
from composerrequirechecker.
Handled in #85
from composerrequirechecker.
Related Issues (20)
- Fatal error: Allowed memory size of 134217728 bytes exhausted HOT 1
- mixed parameter type HOT 6
- constant checks HOT 2
- Parse error with T_PAAMAYIM_NEKUDOTAYIM HOT 2
- Remove ext-tokenizer warnings HOT 2
- Unresolved `getallheaders` function HOT 1
- Default config path HOT 1
- Expose a composer plugin HOT 1
- Reporting missing `ext-random` an PHP 8.2 HOT 5
- GitLab CI Failing even with the command running as expected HOT 11
- [Question] Monorepo setup HOT 12
- Dependency Dashboard
- Switch default branch to `4.6.x` HOT 3
- False positive on Laravel\Illuminate packages HOT 4
- There were no symbols found Error HOT 4
- Distribution using phive & composer HOT 5
- Feature request; take into account require-dev and suggest HOT 6
- GPG signature failed while tagging HOT 6
- PHP Attributes support HOT 3
- False negative when not updating .lock correctly HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from composerrequirechecker.