Giter VIP home page Giter VIP logo

Comments (10)

kitsunet avatar kitsunet commented on June 16, 2024 1

Sure, that would work!

from composerrequirechecker.

Ocramius avatar Ocramius commented on June 16, 2024

Overall understandable request, but really, I'd rather throw an exception that says it is unsupported. I even throw exceptions when I find a custom "vendor-dir" (on other projects of mine). It breaks so many assumptions that you'd really need to go hunting around the ecosystem in general.

from composerrequirechecker.

kitsunet avatar kitsunet commented on June 16, 2024

Yep, I can see that. I am fine with that. Took me a bit to figure out why it literally didn't find any of the dependencies in a project were that is all custom...
I guess having a "not supported" message would be something :)

Maybe I create just a super custom version for that.

from composerrequirechecker.

Ocramius avatar Ocramius commented on June 16, 2024

Took me a bit to figure out why it literally didn't find any of the dependencies in a project were that is all custom...

Instead of detecting from composer.json, we may ask the user for a path - probably better? Would allow testing projects with multiple composer installations too.

from composerrequirechecker.

SvenRtbg avatar SvenRtbg commented on June 16, 2024

Supporting vendor-dir should be easy to do. The mentioned code already gets the composer.json path to the main project and already reads that file to scan for "require" dependencies.

Adding to read the value of ["config"]["vendor-dir"] and assuming "vendor" as default shouldn't be too much hassle. Note that this config value is "root-only", so it basically is just using one fixed or one dynamic directory name.

Haven't looked into install-dir, but because this is per-package required, I'd rather just emit a notice if possible.

What do you think? Adding support for vendor-dir?

from composerrequirechecker.

Ocramius avatar Ocramius commented on June 16, 2024

@SvenRtbg send a patch :-)

from composerrequirechecker.

SvenRtbg avatar SvenRtbg commented on June 16, 2024

Here we are, I have a patch proposal.

from composerrequirechecker.

SvenRtbg avatar SvenRtbg commented on June 16, 2024

While I'm at it: Why does this project allow minimum-stability:dev for it's dependencies? I get it from the commit history that once the nikic/php-parser version 2 required was unstable, but this never got reverted even though stable versions are available for everything.

from composerrequirechecker.

Ocramius avatar Ocramius commented on June 16, 2024

@SvenRtbg separate patch if you want - I think it's just a leftover :)

from composerrequirechecker.

Ocramius avatar Ocramius commented on June 16, 2024

Handled in #85

from composerrequirechecker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.