Giter VIP home page Giter VIP logo

Comments (2)

dvandersluis avatar dvandersluis commented on July 22, 2024 1

I'm not sure if this is something to solve or not but I can see two options:

  1. resetting the primary key values in previous_model. This appears like it should be safe, since this model is never used for anything other than determining the column name.
  2. communicating not to rely on primary key values inside the column_name proc

from counter_culture.

magnusvk avatar magnusvk commented on July 22, 2024

Fascinating. This makes sense to me. I have two thoughts:

  1. It feels like you're misusing the column_name proc. It was intended to just check the state of the current model. There are performance implications of triggering another query each time this is called.
  2. That being said, I agree with you that setting the id on the dup'ed model should be safe, so I'd be happy to accept a PR to add that if you want to put one together.

from counter_culture.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.