Giter VIP home page Giter VIP logo

Comments (6)

maharmstone avatar maharmstone commented on July 26, 2024

Yep, it's on my list! Probably not the next version, but the one after that.

I don't think there's an existing Windows ioctl I can co-opt though... I'm not sure FSCTL_SIS_COPYFILE does what we need it to. You might have to patch your program to get it to use the right fsctl.

from btrfs.

0xbadfca11 avatar 0xbadfca11 commented on July 26, 2024

@maharmstone Windows 10 & Server 2016 has FSCTL_DUPLICATE_EXTENTS_TO_FILE, and FILE_SUPPORTS_BLOCK_REFCOUNTING indicating that filesystem supports it.
This FSCTL is similar to BTRFS_IOC_CLONE_RANGE.
Veeam Backup & Replication software and Hyper-V version 2016 is already using this.

from btrfs.

maharmstone avatar maharmstone commented on July 26, 2024

Thank you, that looks promising.

from btrfs.

maharmstone avatar maharmstone commented on July 26, 2024

This is fully implemented now, and will be available in the next version.

from btrfs.

0xbadfca11 avatar 0xbadfca11 commented on July 26, 2024

@maharmstone I'm sorry because I found a critical bug in my reflink code that you referenced. Using FILE_STANDARD_INFO::AllocationSize is not correct when sparse file. When sparse, AllocationSize is size on disk, not round up-ed file size to cluster size.

from btrfs.

maharmstone avatar maharmstone commented on July 26, 2024

Thank you - you're right, I wasn't aware of that. Confusingly, it seems that the AllocationSize in the FCB header isn't necessarily the same as the AllocationSize returned by QueryStandardInfo etc. I've fixed it now: 5347e4b

from btrfs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.