Failure to convert Windows 10 20H2 boot disk about ntfs2btrfs HOT 3 CLOSED

So I've looked at it and the utility is choking on large logical cluster numbers in the data runs because of these kinds of constructs in the source code:

l_val &= (1 << (l * 8)) - 1;

With a large enough l, 1 << (l * 8) will overflow an int and bad things happen. By changing all occurrences to 1ull << (l * 8), the utility managed to complete execution (with warnings about overly large ADS and compressed files, but that's a separate issue).

from ntfs2btrfs.

Brilliant! Thanks for this, that's very helpful.

I believe MSVC's code analyser picks up stuff like this - I'll run it through that and see if it finds anything else similar.

from ntfs2btrfs.

All the arithmetic overflow issues should now be fixed.

from ntfs2btrfs.